Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring for running the tasks in different contexts #40

Merged
merged 3 commits into from
Sep 18, 2015

Conversation

veewee
Copy link
Contributor

@veewee veewee commented Sep 16, 2015

This major refactoring has some BC breaks.
It is possible to specify which task can run in which context.
A console helper is created that is responsible for running the tasks in the console commands.
This way it is easy to reuse the taskrunner in multiple console commands: You will only need to pass a new context.

This PR will make it possible to develop #33.

@aderuwe, @igormukhingmailcom : Can you please review and tell me if you like it or not?

@igormukhingmailcom
Copy link
Contributor

@veewee Looks very cool. I like :)

veewee added a commit that referenced this pull request Sep 18, 2015
Refactoring for running the tasks in different contexts
@veewee veewee merged commit 73a045f into phpro:master Sep 18, 2015
@igormukhingmailcom
Copy link
Contributor

Can you please tag it as 2.0.0 (now or in future when it will be stable) as it has BC break as you said.

@veewee
Copy link
Contributor Author

veewee commented Sep 18, 2015

Hello @igormukhingmailcom,
Since the project is not stable enough, I will be tagging stuff as 0.(major structural changes).(patch or small feature).
The PR is tagged as 0.4.0.
There are still some things I want to change in the codebase before tagging a stable major release.

@veewee veewee deleted the feature-taskcontext branch February 9, 2016 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants