-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No tasks runs when no files changed #33
Comments
You want GrumPHP to validate the full codebase? Currently we only run tasks when files have changed. |
Tasks like phunit/behat/phpspec not executed on separate files. |
If no PHP file has changed during pre-commit, why should these tasks be ran? For example: a front-end designer wants to add a CSS file, and all of a sudden he gets an exceptions on the unit tests which he does not know anything about. This doesn't seem to make much sense to me. What is your opinion @aderuwe ? |
@igormukhingmailcom I spoke to @veewee about this for a couple minutes this morning. |
@aderuwe I thing that its a great idea. |
Also option For example:
WDYT? |
sounds good! This will require some context in which the tasks needs to run. This feature will require some thinking about the architecture of the project and propably BC breaks. |
@igormukhingmailcom +1 on both counts! |
The run command is implemented. This issue can be closed. |
Hi.
When I run
php ./vendor/bin/grumphp git:pre-commit
manually (and have no changed files) - I see green man even shouldn't. So, no tasks executed.But tasks such as 'phpunit', 'phpspec', 'behat' need to be executed.
The text was updated successfully, but these errors were encountered: