Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing Events, Progress and a run command. #48

Merged
merged 11 commits into from
Oct 26, 2015

Conversation

veewee
Copy link
Contributor

@veewee veewee commented Oct 24, 2015

This PR will make it possible to:

  • Hook in GrumPHP through events
  • Display progress when runnning tasks. This way you know WHY a commit is taking a long time. It is always enabled at the moment but could be configurable in the future.
  • A basic run command that will run the commands on all the files that are registered to git.
  • A new locator that can find out which files are and will be committed to git.
  • Use the grumphp command system-wide

This will resolve issues: #46, #33, #20 and #42.
For know it seems enough for CI to be able to run the tasks with the run command.

Another issue should be opened to make it possible to skip tests when running the tasks.

Can you take a look at this @aderuwe, @igormukhingmailcom ? Thanks!

*/
class TaskFailedEvent extends TaskEvent
{

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra empty line here.

@aderuwe
Copy link
Contributor

aderuwe commented Oct 26, 2015

I'm 👍

@veewee
Copy link
Contributor Author

veewee commented Oct 26, 2015

I removed the newlines. However php-cs is not complaining and there are still other classes with extra newlines. Maybe the PHP-cs standard should be adjusted?

veewee added a commit that referenced this pull request Oct 26, 2015
Introducing Events, Progress and a run command.
Fixes #46, #33, #20, #42.
@veewee veewee merged commit 8457213 into phpro:master Oct 26, 2015
@veewee veewee deleted the feature-progressbar branch February 9, 2016 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants