Support all atomic types as nullable types #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
force-pushed
the
nullable-atomic
branch
from
d1c70d7
to
f61d39a
Compare
|
Perfect! I'm eager to merge this too :) |
rvanvelzen
force-pushed
the
nullable-atomic
branch
from
f61d39a
to
07514e0
Compare
|
Thank you! |
|
FYI I'm gonna try phpdoc-parser in phpstan-src again after this suggestion phpstan/phpstan-src#1406 (comment) - I think it's really necessary to make it optional and non-default because the new behaviour is much stricter and will make a lot of projects fail, so it's a good fit for bleedingEdge (and will allow us to release it in a minor phpdoc-parser version). |
|
But I understand it's not trivial. Ideally I'd like to see all current data providers to be tested with both |
|
I'll hopefully get to it tomorrow :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124