Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type parsing when combinding nullable and consts-types #124

Closed
puggan opened this issue May 18, 2022 · 2 comments · Fixed by #129
Closed

Type parsing when combinding nullable and consts-types #124

puggan opened this issue May 18, 2022 · 2 comments · Fixed by #129

Comments

@puggan
Copy link

puggan commented May 18, 2022

Bug report

Using nullable ? on Consts-types isn't parsed as expected

Code snippet that reproduces the problem

https://phpstan.org/r/d9e3f9e8-eca3-4380-8dda-ecf015d6a322

image

Expected output

No error, expected type ?Currency::CURRENCY_* and null|Currency::CURRENCY_* to be equal.

Did PHPStan help you today? Did it make you happy in any way?

Happy as in "Yes, catched that before commitin/pushing/deploying it"

@ondrejmirtes ondrejmirtes transferred this issue from phpstan/phpstan May 18, 2022
@ondrejmirtes
Copy link
Member

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants