Skip to content

Commit

Permalink
Updated PHP-Parser
Browse files Browse the repository at this point in the history
  • Loading branch information
@ondrejmirtes
ondrejmirtes committed May 4, 2021
1 parent f661fe5 commit 4ee1fa1
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 16 deletions.
4 changes: 2 additions & 2 deletions composer.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@
"nette/neon": "^3.0",
"nette/schema": "^1.0",
"nette/utils": "^3.1.3",
"nikic/php-parser": "4.10.4",
"nikic/php-parser": "4.10.5",

This comment has been minimized.

Sign in to view

Copy link
@TomasVotruba

TomasVotruba May 4, 2021

Contributor

👍

This comment has been minimized.

Sign in to view

Copy link
@TomasVotruba

TomasVotruba May 4, 2021 •
edited
Loading

Contributor

Hi @ondrejmirtes ,
this would help Rector to run on the same php-version and fix missing T_ENUM crash.

Any plans to release it today? 🙂

This comment has been minimized.

Sign in to view

Copy link
@ondrejmirtes

ondrejmirtes May 4, 2021

Author Member

Hi, I still need to some work around the new exception and @throws related rules. Do you have an actual blocker that's preventing you from work, or do you just want to implement Enum-related rules? If it's the latter, I think it can wait since PHP 8.1 isn't going to be released for 6 months...

This comment has been minimized.

Sign in to view

Copy link
@TomasVotruba

TomasVotruba May 4, 2021

Contributor

It's currently crashing on latest Rector, because Rector's stable version is 4.10.5 nad PHPStan is 4.10.4.
Even with preload.php there is a conflict, because when Rector creates PHPStan container, the T_ENUM constant is missing in it.
rectorphp/rector#6322

This comment has been minimized.

Sign in to view

Copy link
@ondrejmirtes

ondrejmirtes May 8, 2021

Author Member

@TomasVotruba FYI I just released PHPStan 0.12.86 with updated PHP-Parser: https://github.com/phpstan/phpstan/releases/tag/0.12.86

The aforementioned @throws rules will take some more time to finish so I decided to tag new PHPStan now.
"ondram/ci-detector": "^3.4.0",
"ondrejmirtes/better-reflection": "4.3.56",
"ondrejmirtes/better-reflection": "4.3.57",
"phpstan/php-8-stubs": "^0.1.16",
"phpstan/phpdoc-parser": "^0.5.4",
"react/child-process": "^0.6.1",
Expand Down
28 changes: 14 additions & 14 deletions composer.lock
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 4ee1fa1

Please sign in to comment.