Only in bleeding edge

phpstan · Apr 16, 2024 · 6026869 · 6026869
1 parent 4293f99
commit 6026869
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 9 deletions.
diff --git a/conf/config.level4.neon b/conf/config.level4.neon
@@ -8,7 +8,6 @@ rules:
 	- PHPStan\Rules\DeadCode\UnusedPrivateMethodRule
 	- PHPStan\Rules\Exceptions\OverwrittenExitPointByFinallyRule
 	- PHPStan\Rules\Functions\CallToFunctionStatementWithoutSideEffectsRule
-	- PHPStan\Rules\Methods\CallToConstructorStatementWithoutSideEffectsRule
 	- PHPStan\Rules\Methods\CallToMethodStatementWithoutSideEffectsRule
 	- PHPStan\Rules\Methods\CallToStaticMethodStatementWithoutSideEffectsRule
 	- PHPStan\Rules\Methods\NullsafeMethodCallRule
@@ -217,6 +216,13 @@ services:
 		tags:
 			- phpstan.rules.rule
 
+	-
+		class: PHPStan\Rules\Methods\CallToConstructorStatementWithoutSideEffectsRule
+		arguments:
+			reportNoConstructor: %featureToggles.pure%
+		tags:
+			- phpstan.rules.rule
+
 	-
 		class: PHPStan\Rules\TooWideTypehints\TooWideMethodReturnTypehintRule
 		arguments:

diff --git a/src/Rules/Methods/CallToConstructorStatementWithoutSideEffectsRule.php b/src/Rules/Methods/CallToConstructorStatementWithoutSideEffectsRule.php
@@ -16,7 +16,10 @@
 class CallToConstructorStatementWithoutSideEffectsRule implements Rule
 {
 
-	public function __construct(private ReflectionProvider $reflectionProvider)
+	public function __construct(
+		private ReflectionProvider $reflectionProvider,
+		private bool $reportNoConstructor,
+	)
 	{
 	}
 
@@ -43,12 +46,16 @@ public function processNode(Node $node, Scope $scope): array
 
 		$classReflection = $this->reflectionProvider->getClass($className);
 		if (!$classReflection->hasConstructor()) {
-			return [
-				RuleErrorBuilder::message(sprintf(
-					'Call to new %s() on a separate line has no effect.',
-					$classReflection->getDisplayName(),
-				))->identifier('new.resultUnused')->build(),
-			];
+			if ($this->reportNoConstructor) {
+				return [
+					RuleErrorBuilder::message(sprintf(
+						'Call to new %s() on a separate line has no effect.',
+						$classReflection->getDisplayName(),
+					))->identifier('new.resultUnused')->build(),
+				];
+			}
+
+			return [];
 		}
 
 		$constructor = $classReflection->getConstructor();

diff --git a/tests/PHPStan/Rules/Methods/CallToConstructorStatementWithoutSideEffectsRuleTest.php b/tests/PHPStan/Rules/Methods/CallToConstructorStatementWithoutSideEffectsRuleTest.php
@@ -13,7 +13,7 @@ class CallToConstructorStatementWithoutSideEffectsRuleTest extends RuleTestCase
 
 	protected function getRule(): Rule
 	{
-		return new CallToConstructorStatementWithoutSideEffectsRule($this->createReflectionProvider());
+		return new CallToConstructorStatementWithoutSideEffectsRule($this->createReflectionProvider(), true);
 	}
 
 	public function testRule(): void