MissingTypehintCheck - do not report iterable template types

phpstan · May 2, 2020 · a7893a8 · a7893a8
1 parent 2d1cac0
commit a7893a8
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/src/Rules/MissingTypehintCheck.php b/src/Rules/MissingTypehintCheck.php
@@ -4,6 +4,7 @@
 
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Type\Generic\GenericObjectType;
+use PHPStan\Type\Generic\TemplateType;
 use PHPStan\Type\Generic\TemplateTypeHelper;
 use PHPStan\Type\MixedType;
 use PHPStan\Type\ObjectType;
@@ -57,6 +58,9 @@ public function getIterableTypesWithMissingValueTypehint(Type $type): array
 
 		$iterablesWithMissingValueTypehint = [];
 		TypeTraverser::map($type, function (Type $type, callable $traverse) use (&$iterablesWithMissingValueTypehint): Type {
+			if ($type instanceof TemplateType) {
+				return $type;
+			}
 			if ($type->isIterable()->yes()) {
 				$iterableValue = $type->getIterableValueType();
 				if ($iterableValue instanceof MixedType && !$iterableValue->isExplicitMixed()) {

diff --git a/tests/PHPStan/Rules/Methods/data/missing-method-parameter-typehint.php b/tests/PHPStan/Rules/Methods/data/missing-method-parameter-typehint.php
@@ -130,3 +130,17 @@ public function acceptsCollection3(\DoctrineIntersectionTypeIsSupertypeOf\Collec
 	}
 
 }
+
+class TraversableInTemplateBound
+{
+
+	/**
+	 * @template T of \Iterator
+	 * @param T $it
+	 */
+	public function doFoo($it)
+	{
+
+	}
+
+}