feat: change isOffsetAccessLegal to maybe

phpstan · May 11, 2024 · de8660d · de8660d
1 parent a23a9f8
commit de8660d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/Type/StrictMixedType.php b/src/Type/StrictMixedType.php
@@ -332,7 +332,7 @@ public function isOffsetAccessLegal(): TrinaryLogic
 				return TrinaryLogic::createYes();
 			}
 		}
-		return TrinaryLogic::createNo();
+		return TrinaryLogic::createMaybe();
 	}
 
 	public function hasOffsetValueType(Type $offsetType): TrinaryLogic

diff --git a/tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php b/tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php
@@ -551,6 +551,7 @@ public function testBug7229(): void
 			[
 				'Cannot access offset string on mixed.',
 				24,
+				'To offset access on this value, narrow down the type by filtering classes not implementing ArrayAccess::class.',
 			],
 		]);
 	}
@@ -732,6 +733,7 @@ public function testBug9991(): void
 			[
 				'Cannot access offset \'title\' on mixed.',
 				9,
+				'To offset access on this value, narrow down the type by filtering classes not implementing ArrayAccess::class.',
 			],
 		]);
 	}
@@ -775,6 +777,7 @@ public function testMixed(): void
 			[
 				'Cannot access offset 5 on T of mixed.',
 				12,
+				'To offset access on this value, narrow down the type by filtering classes not implementing ArrayAccess::class.',
 			],
 			[
 				'Cannot access offset 5 on T of mixed.',
@@ -787,6 +790,7 @@ public function testMixed(): void
 			[
 				'Cannot access offset 5 on mixed.',
 				25,
+				'To offset access on this value, narrow down the type by filtering classes not implementing ArrayAccess::class.',
 			],
 			[
 				'Cannot access offset 5 on mixed.',
@@ -799,6 +803,7 @@ public function testMixed(): void
 			[
 				'Cannot access offset 5 on mixed.',
 				38,
+				'To offset access on this value, narrow down the type by filtering classes not implementing ArrayAccess::class.',
 			],
 			[
 				'Cannot access offset 5 on mixed.',