[BCB] Drop optional reflection interfaces

phpstan · Jul 18, 2019 · e13c685 · e13c685
1 parent 98362bc
commit e13c685
Show file tree

Hide file tree

Showing 30 changed files with 332 additions and 111 deletions.
diff --git a/src/Reflection/Annotations/AnnotationMethodReflection.php b/src/Reflection/Annotations/AnnotationMethodReflection.php
@@ -6,6 +6,7 @@
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\FunctionVariant;
 use PHPStan\Reflection\MethodReflection;
+use PHPStan\TrinaryLogic;
 use PHPStan\Type\Generic\TemplateTypeMap;
 use PHPStan\Type\Type;
 
@@ -106,4 +107,29 @@ public function getVariants(): array
 		return $this->variants;
 	}
 
+	public function isDeprecated(): TrinaryLogic
+	{
+		return TrinaryLogic::createNo();
+	}
+
+	public function getDeprecatedDescription(): ?string
+	{
+		return null;
+	}
+
+	public function isFinal(): TrinaryLogic
+	{
+		return TrinaryLogic::createNo();
+	}
+
+	public function isInternal(): TrinaryLogic
+	{
+		return TrinaryLogic::createNo();
+	}
+
+	public function getThrowType(): ?Type
+	{
+		return null;
+	}
+
 }
diff --git a/src/Reflection/Annotations/AnnotationPropertyReflection.php b/src/Reflection/Annotations/AnnotationPropertyReflection.php
@@ -4,6 +4,7 @@
 
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\PropertyReflection;
+use PHPStan\TrinaryLogic;
 use PHPStan\Type\Type;
 
 class AnnotationPropertyReflection implements PropertyReflection
@@ -69,4 +70,19 @@ public function isWritable(): bool
 		return $this->writable;
 	}
 
+	public function isDeprecated(): TrinaryLogic
+	{
+		return TrinaryLogic::createNo();
+	}
+
+	public function getDeprecatedDescription(): ?string
+	{
+		return null;
+	}
+
+	public function isInternal(): TrinaryLogic
+	{
+		return TrinaryLogic::createNo();
+	}
+
 }
diff --git a/src/Reflection/ClassConstantReflection.php b/src/Reflection/ClassConstantReflection.php
@@ -4,7 +4,7 @@
 
 use PHPStan\TrinaryLogic;
 
-class ClassConstantReflection implements ConstantReflection, DeprecatableReflection, InternableReflection
+class ClassConstantReflection implements ConstantReflection
 {
 
 	/** @var \PHPStan\Reflection\ClassReflection */

diff --git a/src/Reflection/ConstantReflection.php b/src/Reflection/ConstantReflection.php
@@ -2,6 +2,8 @@
 
 namespace PHPStan\Reflection;
 
+use PHPStan\TrinaryLogic;
+
 interface ConstantReflection extends ClassMemberReflection
 {
 
@@ -12,4 +14,10 @@ public function getName(): string;
 	 */
 	public function getValue();
 
+	public function isDeprecated(): TrinaryLogic;
+
+	public function getDeprecatedDescription(): ?string;
+
+	public function isInternal(): TrinaryLogic;
+
 }
diff --git a/src/Reflection/DeprecatableReflection.php b/src/Reflection/DeprecatableReflection.php
diff --git a/src/Reflection/Dummy/DummyConstantReflection.php b/src/Reflection/Dummy/DummyConstantReflection.php
@@ -5,6 +5,7 @@
 use PHPStan\Broker\Broker;
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\ConstantReflection;
+use PHPStan\TrinaryLogic;
 
 class DummyConstantReflection implements ConstantReflection
 {
@@ -53,4 +54,19 @@ public function getValue()
 		return new \stdClass();
 	}
 
+	public function isDeprecated(): TrinaryLogic
+	{
+		return TrinaryLogic::createMaybe();
+	}
+
+	public function getDeprecatedDescription(): ?string
+	{
+		return null;
+	}
+
+	public function isInternal(): TrinaryLogic
+	{
+		return TrinaryLogic::createMaybe();
+	}
+
 }
diff --git a/src/Reflection/Dummy/DummyConstructorReflection.php b/src/Reflection/Dummy/DummyConstructorReflection.php
@@ -6,7 +6,9 @@
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\FunctionVariant;
 use PHPStan\Reflection\MethodReflection;
+use PHPStan\TrinaryLogic;
 use PHPStan\Type\Generic\TemplateTypeMap;
+use PHPStan\Type\Type;
 use PHPStan\Type\VoidType;
 
 class DummyConstructorReflection implements MethodReflection
@@ -62,4 +64,29 @@ public function getVariants(): array
 		];
 	}
 
+	public function isDeprecated(): TrinaryLogic
+	{
+		return TrinaryLogic::createMaybe();
+	}
+
+	public function getDeprecatedDescription(): ?string
+	{
+		return null;
+	}
+
+	public function isFinal(): TrinaryLogic
+	{
+		return TrinaryLogic::createMaybe();
+	}
+
+	public function isInternal(): TrinaryLogic
+	{
+		return TrinaryLogic::createMaybe();
+	}
+
+	public function getThrowType(): ?Type
+	{
+		return null;
+	}
+
 }
diff --git a/src/Reflection/Dummy/DummyMethodReflection.php b/src/Reflection/Dummy/DummyMethodReflection.php
@@ -7,6 +7,8 @@
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Reflection\TrivialParametersAcceptor;
+use PHPStan\TrinaryLogic;
+use PHPStan\Type\Type;
 
 class DummyMethodReflection implements MethodReflection
 {
@@ -61,4 +63,29 @@ public function getVariants(): array
 		];
 	}
 
+	public function isDeprecated(): TrinaryLogic
+	{
+		return TrinaryLogic::createMaybe();
+	}
+
+	public function getDeprecatedDescription(): ?string
+	{
+		return null;
+	}
+
+	public function isFinal(): TrinaryLogic
+	{
+		return TrinaryLogic::createMaybe();
+	}
+
+	public function isInternal(): TrinaryLogic
+	{
+		return TrinaryLogic::createMaybe();
+	}
+
+	public function getThrowType(): ?Type
+	{
+		return null;
+	}
+
 }
diff --git a/src/Reflection/Dummy/DummyPropertyReflection.php b/src/Reflection/Dummy/DummyPropertyReflection.php
@@ -5,6 +5,7 @@
 use PHPStan\Broker\Broker;
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\PropertyReflection;
+use PHPStan\TrinaryLogic;
 use PHPStan\Type\MixedType;
 use PHPStan\Type\Type;
 
@@ -48,4 +49,19 @@ public function isWritable(): bool
 		return true;
 	}
 
+	public function isDeprecated(): TrinaryLogic
+	{
+		return TrinaryLogic::createMaybe();
+	}
+
+	public function getDeprecatedDescription(): ?string
+	{
+		return null;
+	}
+
+	public function isInternal(): TrinaryLogic
+	{
+		return TrinaryLogic::createMaybe();
+	}
+
 }
diff --git a/src/Reflection/FinalizableReflection.php b/src/Reflection/FinalizableReflection.php
diff --git a/src/Reflection/FunctionReflection.php b/src/Reflection/FunctionReflection.php
@@ -2,7 +2,10 @@
 
 namespace PHPStan\Reflection;
 
-interface FunctionReflection extends DeprecatableReflection, InternableReflection, FinalizableReflection, ThrowableReflection
+use PHPStan\TrinaryLogic;
+use PHPStan\Type\Type;
+
+interface FunctionReflection
 {
 
 	public function getName(): string;
@@ -12,4 +15,14 @@ public function getName(): string;
 	 */
 	public function getVariants(): array;
 
+	public function isDeprecated(): TrinaryLogic;
+
+	public function getDeprecatedDescription(): ?string;
+
+	public function isFinal(): TrinaryLogic;
+
+	public function isInternal(): TrinaryLogic;
+
+	public function getThrowType(): ?Type;
+
 }
diff --git a/src/Reflection/InternableReflection.php b/src/Reflection/InternableReflection.php
diff --git a/src/Reflection/MethodReflection.php b/src/Reflection/MethodReflection.php
@@ -2,6 +2,9 @@
 
 namespace PHPStan\Reflection;
 
+use PHPStan\TrinaryLogic;
+use PHPStan\Type\Type;
+
 interface MethodReflection extends ClassMemberReflection
 {
 
@@ -14,4 +17,14 @@ public function getPrototype(): ClassMemberReflection;
 	 */
 	public function getVariants(): array;
 
+	public function isDeprecated(): TrinaryLogic;
+
+	public function getDeprecatedDescription(): ?string;
+
+	public function isFinal(): TrinaryLogic;
+
+	public function isInternal(): TrinaryLogic;
+
+	public function getThrowType(): ?Type;
+
 }
diff --git a/src/Reflection/Native/NativeFunctionReflection.php b/src/Reflection/Native/NativeFunctionReflection.php
@@ -46,11 +46,6 @@ public function getVariants(): array
 		return $this->variants;
 	}
 
-	public function hasThrowType(): TrinaryLogic
-	{
-		return TrinaryLogic::createYes();
-	}
-
 	public function getThrowType(): ?Type
 	{
 		return $this->throwType;

diff --git a/src/Reflection/Native/NativeMethodReflection.php b/src/Reflection/Native/NativeMethodReflection.php
@@ -5,15 +5,13 @@
 use PHPStan\Broker\Broker;
 use PHPStan\Reflection\ClassMemberReflection;
 use PHPStan\Reflection\ClassReflection;
-use PHPStan\Reflection\DeprecatableReflection;
-use PHPStan\Reflection\FinalizableReflection;
-use PHPStan\Reflection\InternableReflection;
 use PHPStan\Reflection\MethodPrototypeReflection;
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Reflection\Php\BuiltinMethodReflection;
 use PHPStan\TrinaryLogic;
+use PHPStan\Type\Type;
 
-class NativeMethodReflection implements MethodReflection, DeprecatableReflection, InternableReflection, FinalizableReflection
+class NativeMethodReflection implements MethodReflection
 {
 
 	/** @var \PHPStan\Broker\Broker */
@@ -117,4 +115,9 @@ public function isFinal(): TrinaryLogic
 		return TrinaryLogic::createNo();
 	}
 
+	public function getThrowType(): ?Type
+	{
+		return null;
+	}
+
 }
diff --git a/src/Reflection/Php/PhpFunctionFromParserNodeReflection.php b/src/Reflection/Php/PhpFunctionFromParserNodeReflection.php
@@ -221,11 +221,6 @@ public function isFinal(): TrinaryLogic
 		return TrinaryLogic::createFromBoolean($this->isFinal);
 	}
 
-	public function hasThrowType(): TrinaryLogic
-	{
-		return TrinaryLogic::createYes();
-	}
-
 	public function getThrowType(): ?Type
 	{
 		return $this->throwType;

diff --git a/src/Reflection/Php/PhpFunctionReflection.php b/src/Reflection/Php/PhpFunctionReflection.php
@@ -271,11 +271,6 @@ public function isFinal(): TrinaryLogic
 		return TrinaryLogic::createFromBoolean($this->isFinal);
 	}
 
-	public function hasThrowType(): TrinaryLogic
-	{
-		return TrinaryLogic::createYes();
-	}
-
 	public function getThrowType(): ?Type
 	{
 		return $this->phpDocThrowType;