static and global cannot be used in pure context

phpstan · Apr 3, 2024 · f659df5 · f659df5
1 parent d303c60
commit f659df5
Show file tree

Hide file tree

Showing 4 changed files with 47 additions and 3 deletions.
diff --git a/src/Analyser/ImpurePoint.php b/src/Analyser/ImpurePoint.php
@@ -6,7 +6,7 @@
 use PHPStan\Node\VirtualNode;
 
 /**
- * @phpstan-type ImpurePointIdentifier = 'echo'|'die'|'exit'|'propertyAssign'|'methodCall'|'new'|'functionCall'|'include'|'require'|'print'|'eval'|'superglobal'|'yield'|'yieldFrom'
+ * @phpstan-type ImpurePointIdentifier = 'echo'|'die'|'exit'|'propertyAssign'|'methodCall'|'new'|'functionCall'|'include'|'require'|'print'|'eval'|'superglobal'|'yield'|'yieldFrom'|'static'|'global'
  * @api
  */
 class ImpurePoint

diff --git a/src/Analyser/NodeScopeResolver.php b/src/Analyser/NodeScopeResolver.php
@@ -1691,7 +1691,15 @@ static function (Node $node, Scope $scope) use ($nodeCallback): void {
 		} elseif ($stmt instanceof Node\Stmt\Global_) {
 			$hasYield = false;
 			$throwPoints = [];
-			$impurePoints = [];
+			$impurePoints = [
+				new ImpurePoint(
+					$scope,
+					$stmt,
+					'global',
+					'global variable',
+					true,
+				),
+			];
 			$vars = [];
 			foreach ($stmt->vars as $var) {
 				if (!$var instanceof Variable) {
@@ -1713,7 +1721,15 @@ static function (Node $node, Scope $scope) use ($nodeCallback): void {
 		} elseif ($stmt instanceof Static_) {
 			$hasYield = false;
 			$throwPoints = [];
-			$impurePoints = [];
+			$impurePoints = [
+				new ImpurePoint(
+					$scope,
+					$stmt,
+					'static',
+					'static variable',
+					true,
+				),
+			];
 
 			$vars = [];
 			foreach ($stmt->vars as $var) {

diff --git a/tests/PHPStan/Rules/Pure/PureFunctionRuleTest.php b/tests/PHPStan/Rules/Pure/PureFunctionRuleTest.php
@@ -79,6 +79,14 @@ public function testRule(): void
 				'Impure access to superglobal variable in pure function PureFunction\pureButAccessSuperGlobal().',
 				104,
 			],
+			[
+				'Impure global variable in pure function PureFunction\functionWithGlobal().',
+				117,
+			],
+			[
+				'Impure static variable in pure function PureFunction\functionWithStaticVariable().',
+				127,
+			],
 		]);
 	}
 

diff --git a/tests/PHPStan/Rules/Pure/data/pure-function.php b/tests/PHPStan/Rules/Pure/data/pure-function.php
@@ -108,3 +108,23 @@ function emptyVoidFunctionWithByRefParameter(&$a): void
 {
 
 }
+
+/**
+ * @phpstan-pure
+ */
+function functionWithGlobal(): int
+{
+	global $db;
+
+	return 1;
+}
+
+/**
+ * @phpstan-pure
+ */
+function functionWithStaticVariable(): int
+{
+	static $v = 1;
+
+	return $v;
+}