Handle invalid input type in filter_var() better

phpstan · Dec 29, 2022 · f9f17d5 · f9f17d5
1 parent e5c3aea
commit f9f17d5
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/src/Type/Php/FilterVarDynamicReturnTypeExtension.php b/src/Type/Php/FilterVarDynamicReturnTypeExtension.php
@@ -157,6 +157,11 @@ public function getTypeFromFunctionCall(
 		$defaultType = $this->hasFlag($this->getConstant('FILTER_NULL_ON_FAILURE'), $flagsType)
 			? new NullType()
 			: new ConstantBooleanType(false);
+
+		if ($inputType->isScalar()->no() && $inputType->isNull()->no()) {
+			return $defaultType;
+		}
+
 		$exactType = $this->determineExactType($inputType, $filterValue, $defaultType, $flagsType);
 		$type = $exactType ?? $this->getFilterTypeMap()[$filterValue] ?? $mixedType;
 

diff --git a/tests/PHPStan/Analyser/data/filter-var.php b/tests/PHPStan/Analyser/data/filter-var.php
@@ -2,6 +2,7 @@
 
 namespace FilterVar;
 
+use stdClass;
 use function PHPStan\Testing\assertType;
 
 class FilterVar
@@ -18,6 +19,15 @@ public function doFoo($mixed): void
 		assertType('array<false>', filter_var(false, FILTER_VALIDATE_BOOLEAN, FILTER_FORCE_ARRAY | FILTER_NULL_ON_FAILURE));
 	}
 
+	/** @param resource $resource */
+	public function invalidInput(array $arr, object $object, $resource): void
+	{
+		assertType('false', filter_var($arr));
+		assertType('false', filter_var($object));
+		assertType('false', filter_var($resource));
+		assertType('null', filter_var(new stdClass(), FILTER_DEFAULT, FILTER_NULL_ON_FAILURE));
+	}
+
 	public function intToInt(int $int, array $options): void
 	{
 		assertType('int', filter_var($int, FILTER_VALIDATE_INT));