Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small signature updates #1126

Merged
merged 1 commit into from Mar 27, 2022
Merged

small signature updates #1126

merged 1 commit into from Mar 27, 2022

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Mar 27, 2022

@ondrejmirtes ondrejmirtes merged commit 4718095 into phpstan:1.5.x Mar 27, 2022
@ondrejmirtes
Copy link
Member

Thank you.

@staabm staabm deleted the signatures branch March 27, 2022 20:35
@dktapps
Copy link
Contributor

dktapps commented Apr 1, 2022

It would be nice if PHPStan had some enum types for these parameters; for example here I'm forced to copy 1|2|3|4 instead of being able to write something like PHP_ROUND_HALF_*, which is a pain if extra parameter values are ever added.

@staabm
Copy link
Contributor Author

staabm commented Apr 1, 2022

I guess phpstan/phpstan#6160 is what you are suggesting?

@dktapps
Copy link
Contributor

dktapps commented Apr 1, 2022

That would make it easier for sure. I previously requested something similar myself but was denied.

However, what I would rather have is some kind of pseudo-enum RoundMode or something of that nature, rather than being forced to write out all these options myself everywhere I pass through such a parameter.

dktapps added a commit to pmmp/Math that referenced this pull request Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants