Add SensitiveParameter stub #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That test could never fail, it's in a wrong class. It's parameter attribute, not class attribute. |
|
🤦 - good catch. moved the test. |
|
Thank you. |
|
for posterity: this needed an additional fix in ondrejmirtes/BetterReflection@7f99a91 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://stitcher.io/blog/new-in-php-82#redact-parameters-in-back-traces-rfc
refs https://wiki.php.net/rfc/redact_parameters_in_back_traces
the RFC mentions another class involved, which is
SensitiveParameterValue.it will only be needed at runtime - as a place-holder for the sensitive value beeing masked, and therefore no additional stubs are required regarding that one.