Hide sensitive information with SensitiveParameter attribute #5189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gharlan
reviewed
Jul 11, 2022
redaxo/src/addons/structure/plugins/history/lib/history_login.php
Outdated
Show resolved
Hide resolved
staabm
commented
Jul 12, 2022
redaxo/src/core/lib/login/login.php
Outdated
Comment on lines
101
to
105
| #[\SensitiveParameter] | ||
| $login, | ||
| #[\SensitiveParameter] | ||
| $password, | ||
| $isPreHashed = false |
There was a problem hiding this comment.
gibts hier noch ein cs fixer setting was wir einstellen könnten, damit die parameter besser eingerückt würden? gibts nen cs-fixer setting wg. attributes auf separater zeile?
staabm
commented
Jul 12, 2022
phpstan.neon.dist
Outdated
| @@ -33,6 +33,7 @@ parameters: | |||
| symfony: | |||
| console_application_loader: .tools/phpstan/console.php | |||
| ignoreErrors: | |||
| - '#.*Attribute class SensitiveParameter does not exist.*#' | |||
There was a problem hiding this comment.
wird in phpstan implementiert mit phpstan/phpstan-src#1511
There was a problem hiding this comment.
Psalm upstream issue:
vimeo/psalm#8262
|
der PR ist fertig.. wir warten auf tool support in phpstan/psalm, siehe linked issues |
|
Alternativ: errors baselinen, da das attribut auch ohne tool support einen mehrwert zur laufzeit hat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature for PHP 8.2: Redact parameters in back traces