Passing a variable by reference to a function and method has side effects

[ryium]

• fixes PHP 8.0 - throw statement is now throw expression, it can throw at any point phpstan#8084

[phpstan-bot]

This pull request has been marked as ready for review.

[ondrejmirtes]

Could you please test and fix other similar functions that might have the same issue? array_push, array_unshift, array_pop, array_splice

[ondrejmirtes]

And maybe it'd be a better to idea to do this in public function hasSideEffects(): TrinaryLogic in various FunctionReflection and MethodReflection implementations - to return TrinaryLogic::createYes() if the function accepts parameters as references.

[ondrejmirtes]

Hi, please put this type into @param above the method, here it's ambiguous what it means.

Also currently this example https://phpstan.org/r/de642079-e5b0-492a-9782-d78c324f70a7 shows Expression on left side of ?? is not nullable. so we'll need another test in NullCoalesceRuleTest to make sure this message goes away.

Thank you!

[ryium]

Hi, thank you for your review.
Added a test, but included a merge commit to follow the latest branch.
Should I recreate?

[ondrejmirtes]

Brought it over the finish line :) Thank you.

[ondrejmirtes]

Sorry, I had to revert this, it led to some false positives.