More precise file() flags args in bleedingEdge #2476
Conversation
|
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x. |
|
This pull request has been marked as ready for review. |
|
Thank you. |
| @@ -107,6 +107,7 @@ | |||
| 'ImagickKernel::scale' => ['void', 'scale'=>'float', 'normalizeFlag'=>'Imagick::NORMALIZE_KERNEL_*'], | |||
| 'max' => ['', '...arg1'=>'non-empty-array'], | |||
| 'min' => ['', '...arg1'=>'non-empty-array'], | |||
| 'file' => ['list<string>|false', 'filename'=>'string', 'flags='=>'0|FILE_USE_INCLUDE_PATH|FILE_IGNORE_NEW_LINES|FILE_SKIP_EMPTY_LINES', 'context='=>'resource'], | |||
There was a problem hiding this comment.
This seems to be missing the FILE_NO_DEFAULT_CONTEXT flag (which is apparently undocumented).
There was a problem hiding this comment.
thanks will have a look
There was a problem hiding this comment.
added via #2482
I missed it, because its missing from https://www.php.net/manual/en/function.file.php - therefore just also sumbitted a php.net docs PR
|
@staabm I don't think this should be reported: https://phpstan.org/r/7cdbe87f-3cd6-4ba7-a1d0-7e2be337d4ed Can you please look into it? Thank you. |
https://www.php.net/manual/en/function.file.php
refs php/php-src#11483