Added missing FILE_NO_DEFAULT_CONTEXT for file()
#2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Jun 23, 2023
| </term> | ||
| <listitem> | ||
| <simpara> | ||
| Don't use the default context |
There was a problem hiding this comment.
I wasn't sure what other implications this flag has. maybe this description could be more useful
There was a problem hiding this comment.
I think that's the only one it has looking at https://heap.space/xref/php-src/main/streams/php_stream_context.h?r=d22d0e26#31
Girgias
approved these changes
Jun 24, 2023
| </term> | ||
| <listitem> | ||
| <simpara> | ||
| Don't use the default context |
There was a problem hiding this comment.
I think that's the only one it has looking at https://heap.space/xref/php-src/main/streams/php_stream_context.h?r=d22d0e26#31
mumumu
added a commit
to php/doc-ja
that referenced
this pull request
Jun 24, 2023
「ストリーム」コンテキストと訳すべきかどうかは疑義があろう。 だが、元のPR ( php/doc-en#2540 ) でも触れられている通り、以下のソースコードの文脈と、context パラメータから、そうとしか読み取れない。またはそう読むのが自然である。 https://heap.space/xref/php-src/main/streams/php_stream_context.h?r=d22d0e26#31-35 php/doc-en@2957432
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems this flag is available but missing from the docs