New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enchant_broker_list_dicts() return type #257

Merged

ondrejmirtes merged 1 commit into phpstan:master from villfa:fix/enchant_broker_list_dicts

Jun 24, 2020

Contributor

villfa commented Jun 24, 2020

enchant_broker_list_dicts() returns an array. See: https://www.php.net/manual/en/function.enchant-broker-list-dicts.php

Member

ondrejmirtes commented Jun 24, 2020

Hi,

The function can also return false: https://www.php.net/manual/en/function.enchant-broker-list-dicts.php
Based on https://www.php.net/manual/en/function.enchant-broker-list-dicts.php, you could write a more specific array shape: https://phpstan.org/writing-php-code/phpdoc-types#array-shapes (the functionMap types are parsed through the same parser as PHPDocs)


          Fix enchant_broker_list_dicts() return type

f2d9846

Contributor Author

villfa commented Jun 24, 2020

I've updated the return type to be more precise

Member

ondrejmirtes commented Jun 24, 2020

Looks great! Thank you.

ondrejmirtes merged commit cdf5b85 into phpstan:master

villfa deleted the fix/enchant_broker_list_dicts branch

June 24, 2020 14:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet