Drop wrong float comparison using PHP_FLOAT_EPSILON #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
no_epsilon_float_cmp
branch
from
cdb6e47
to
656eb7d
Compare
mvorisek
changed the title
mvorisek
force-pushed
the
no_epsilon_float_cmp
branch
from
656eb7d
to
05a8b88
Compare
|
This pull request has been marked as ready for review. |
|
the failing tests are unrelated |
|
These changes need tests to see what they’re sctually fixing. |
|
help welcomed with tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discussion #2358 (comment)
PHP_FLOAT_EPSILONis small but still much larger than "small floating point values" - https://3v4l.org/570q1abs($this->value - $type->value) < PHP_FLOAT_EPSILONcondition for small numbers always wrongly returned true,===is the only valid cmp as long as both left/right side of the operator are of type float