Fix ConstantFloatType value dump precision #2358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x. |
mvorisek
force-pushed
the
fix_float_dump
branch
from
f1a7c78
to
c591aec
Compare
mvorisek
commented
Apr 22, 2023
mvorisek
commented
Apr 22, 2023
staabm
reviewed
Apr 22, 2023
|
|
||
| return $formatted; | ||
| }, | ||
| fn (): string => $this->castFloatToString($this->value), |
There was a problem hiding this comment.
IIRC this is a perf critical path.
I think we need a benchmark to show whether this edge-case fixing leads to a perf regression in the common case
There was a problem hiding this comment.
Scratch that. I mixed it up with #2080
There was a problem hiding this comment.
#2080 - please see phpstan/phpstan#9228, the comparison should be even simplifid to === only, as any other float value is different
|
fwiw, I just stumbled over a pretty similar logic in sebastian/exporter: |
mvorisek
force-pushed
the
fix_float_dump
branch
from
c477b0b
to
fe9bd6d
Compare
mvorisek
force-pushed
the
fix_float_dump
branch
from
1b7e1a0
to
aaaf2c3
Compare
|
PR is done. |
|
Thank you. |
This was referenced May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dumping a float value, we need:
.is always present in finite values (/wo.the number type is integer)(string) float_exprcast is affected byprecisionphp.ini)