Implement RequireExtendsPropertiesClassReflectionExtension

[staabm]

No description provided.

[ondrejmirtes]

Please add some regression tests that use these tags to make sure this actually solves the problems:

• [PHP^8.2] Access to an undefined property when type hinting interface with @property phpstan#10302
• @phpstan-require-use for requiring implementors/subclasses to use certain traits phpstan#9899
• PHP8.2 - Interface property annotation not found inside class phpstan#8550

[staabm]

(just pushed a intermediate state to allow me switching to a different computer over the weekend)

[ondrejmirtes]

Is this recursion guard tested?

[staabm]

I tried thinking of a way this could get recursive, but wasn't able to come up with a example.

do you think its impossible and the recursion-guard should be removed?

[ondrejmirtes]

I'd expect something like this to end up in infinite recursion https://phpstan.org/r/aa768c71-4596-4edf-a900-60e4db58582b

[staabm]

thx for the inspiration. I tried similar things before and I can't force them to endless recurse.

I think this might not happen, because the new extension early exits for non-interfaces and the phpstan-require-extends requires a class as argument.

since I was still not able to force a recursion, I have removed the recursion guards for now

[ondrejmirtes]

This is a point for the rules - @...-require-extends can only be above an interface.

[staabm]

so do you mean we should still try to infer the property across the type hierarchy, even though the require-extends is placed on a invalid location?

[ondrejmirtes]

Sorry, I don't get it. This comment was just a reminder for you to check whether require-extends is always above an interface.

[staabm]

rules will be topic for a followup PR. thanks for noticing.

[phpstan-bot]

This pull request has been marked as ready for review.

[ondrejmirtes]

I merged part of this pull request: 53a61dc

You should be able to rebase this PR cleanly (maybe after you squash all commits).

The reason why I did this is that you can start working on the rules PR in parallel to this PR.

I want to keep 1.10.x releasable and I don't want to merge this PR and then wait several releases for the rules PR to be finished, because I see them as an atomic feature.

You should be able to work on rules in a separate branch/PR without any conflicts.

[ondrejmirtes]

Thank you!

[ondrejmirtes]

FYI this was a missing part: 9ac6fd1

[ondrejmirtes]

About generics - I'd like to support things like:

/**
 * @template T
 * @phpstan-require-extends Model<T>
 */

1. Which would inform about what T is in case the Model typehints it in the accessed property/called method. I think it might already work with the existing code.

2. Also when doing class Foo implements Bar extends Model, it should enforce that the same type in @implements Bar<X> is also used in @extends Model<X>.

3. Also if Model is generic but the user does not declare what T is in @phpstan-require-extends, PHPStan should complain.

4. It should for example also complain when Model has two @template but the number of type variables isn't 2.

For 3) and 4) there are already existing checks which we should just call.

Do you feel up to the task? If you start working on this and hit a roadblock don't worry, open a draft PR and we'll figure out why it doesn't work. Thanks!

[staabm]

FYI this was a missing part: 9ac6fd1

great catch, thank you.

[staabm]

@ondrejmirtes should we add the require-extends and require-implements types to $dependenciesReflections similar how its done for MixinTypes?

phpstan-src/src/Dependency/DependencyResolver.php

Lines 489 to 496 in 9c4508d

	foreach ($classReflection->getResolvedMixinTypes() as $mixinType) {
	foreach ($mixinType->getReferencedClasses() as $referencedClass) {
	if (!$this->reflectionProvider->hasClass($referencedClass)) {
	continue;
	}
	$dependenciesReflections[] = $this->reflectionProvider->getClass($referencedClass);
	}
	}

[ondrejmirtes]

Yes, definitely! Ideally try to simulate in e2e-tests.yml a situation where the result cache gets stale. There arr several examples already.