Allow accessing @property on interface when it requires extending class that allows dynamic properties

Author: ondrejmirtes

src/Reflection/ClassReflection.php

@@ -45,6 +45,7 @@
 use PHPStan\Type\Generic\TemplateTypeVariance;
 use PHPStan\Type\Generic\TemplateTypeVarianceMap;
 use PHPStan\Type\Generic\TypeProjectionHelper;
+use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeAlias;
 use PHPStan\Type\TypehintHelper;
@@ -421,7 +422,30 @@ private function allowsDynamicPropertiesExtensions(): bool
 			return true;
 		}
 
-		return $this->hasNativeMethod('__get') || $this->hasNativeMethod('__set') || $this->hasNativeMethod('__isset');
+		$hasMagicMethod = $this->hasNativeMethod('__get') || $this->hasNativeMethod('__set') || $this->hasNativeMethod('__isset');
+		if ($hasMagicMethod) {
+			return true;
+		}
+
+		foreach ($this->getRequireExtendsTags() as $extendsTag) {
+			$type = $extendsTag->getType();
+			if (!$type instanceof ObjectType) {
+				continue;
+			}
+
+			$reflection = $type->getClassReflection();
+			if ($reflection === null) {
+				continue;
+			}
+
+			if (!$reflection->allowsDynamicPropertiesExtensions()) {
+				continue;
+			}
+
+			return true;
+		}
+
+		return false;
 	}
 
 	public function hasProperty(string $propertyName): bool

tests/PHPStan/Analyser/data/bug-10302.php

@@ -14,7 +14,7 @@ interface BatchAware
 }
 
 /**
- * @property-read bool $busy
+ * @property-read bool $busy2
  */
 class Model
 {
@@ -27,12 +27,29 @@ public function __get(string $name)
 	}
 }
 
-class SomeModel extends Model implements BatchAware
+function (BatchAware $b): void
+{
+	assertType('bool', $b->busy);
+	assertType('bool', $b->busy2);
+};
+
+class ModelWithoutAllowDynamicProperties
 {
 
 }
 
-function (BatchAware $b): void
+/**
+ * @property-read bool $busy
+ * @phpstan-require-extends ModelWithoutAllowDynamicProperties
+ */
+interface BatchAwareWithoutAllowDynamicProperties
 {
-	assertType('bool', $b->busy);
+
+}
+
+function (BatchAwareWithoutAllowDynamicProperties $b): void
+{
+	$result = $b->busy; // @phpstan-ignore-line
+
+	assertType('*ERROR*', $result);
 };