sizeof() is an alias of count()

[staabm]

Refs phpstan/phpstan#2142

see https://www.php.net/sizeof

[ondrejmirtes]

1. This change needs a test.
2. There are definitely more places that need fixing. Search for 'count' in src/

[staabm]

great feedback - as always. I think the PR is now in better shape.

[ondrejmirtes]

Thank you!

[staabm]

I was not sure whether I should have added sizeof here to:

phpstan-src/src/Analyser/TypeSpecifier.php

Lines 403 to 423 in fc7bcff

	if (
	$expr->left instanceof FuncCall
	&& count($expr->left->args) === 1
	&& $expr->left->name instanceof Name
	&& in_array(strtolower((string) $expr->left->name), ['count', 'strlen'], true)
	&& (
	!$expr->right instanceof FuncCall
	|| !$expr->right->name instanceof Name
	|| !in_array(strtolower((string) $expr->right->name), ['count', 'strlen'], true)
	)
	) {
	$inverseOperator = $expr instanceof Node\Expr\BinaryOp\Smaller
	? new Node\Expr\BinaryOp\SmallerOrEqual($expr->right, $expr->left)
	: new Node\Expr\BinaryOp\Smaller($expr->right, $expr->left);
	return $this->specifyTypesInCondition(
	$scope,
	new Node\Expr\BooleanNot($inverseOperator),
	$context
	);
	}

maybe you can give me a hint

[ondrejmirtes]

Yeah, probably, this branch probably solves something like count($a) > 0 or something.