added sizeof() as alias of count() for Smaller/SmallerOrEqual
#648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Aug 27, 2021
|
the latest commit covers another case regarding 0 != count(), regarding non-empty-array type |
staabm
changed the title
sizeof() as alias of count for Smaller/SmallerOrEqual
staabm
changed the title
sizeof() as alias of count for Smaller/SmallerOrEqualsizeof() as alias of count() for Smaller/SmallerOrEqual
ondrejmirtes
requested changes
Aug 27, 2021
| function doFoo3(array $arr): string | ||
| { | ||
| if (0 != count($arr)) { | ||
| assertType('string', reset($arr)); | ||
| assertType('array&nonEmpty', $arr); |
There was a problem hiding this comment.
This is basically deleting an existing test. Please add additional line instead of deleting this.
There was a problem hiding this comment.
Oh sorry, I misread the commit history, it's fine.
ondrejmirtes
approved these changes
Aug 27, 2021
|
Thank you. |
This was referenced Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
triggered by #647 (comment)