Add "DynamicFunctionReturnTypeExtension" for "array_replace" + fix for "array_merge" #696
Conversation
| $argType = $argType->getIterableValueType(); | ||
| if ($argType instanceof UnionType) { | ||
| foreach ($argType->getTypes() as $innerType) { | ||
| $argType = $innerType; |
There was a problem hiding this comment.
I don't understand this part - the last inner type in the union will win in the $argType variable?
There was a problem hiding this comment.
I know the same code is in ArrayMergeFunctionDynamicReturnTypeExtension - it also puzzles me there.
There was a problem hiding this comment.
It makes no sense to me. Maybe this https://github.com/phpstan/phpstan-src/pull/622/files#diff-2b90d7b4bf7114d779c5be8175b43e99ebb849c71781c4285c6cc47bb6cba5d3R40 is more correct?
There was a problem hiding this comment.
I don't know, you tell me :(
There was a problem hiding this comment.
In the last pull request we already tried to process every parameter. I could re-add it, so we can see if it works, but the performance was bad, so that I will not add anything related to array shapes, ok?
There was a problem hiding this comment.
Let's try and see what happens :)
There was a problem hiding this comment.
I re-added the fixes and added a limit for the array. I also added the fix for "array_merge" here, so we can see the differences between the implementations in one diff.
If we check the type of the key, then we could implement the correct behavior in the future. |
voku
changed the title
There was a problem hiding this comment.
Please add a regression test for phpstan/phpstan#5846 here and I'll take a look :) Thank you.
I re-added some changes, even more tests and added some checks to prevent performance issues, but maybe we need to adjust the consts "MAX_*" settings? I already tested the performance with a private project and blackfire.io and for me, it looks good, but as airways it depends on the tested code. |
+ try to prevent performance issues from it: maybe we need to adjust the consts "MAX_*"
ondrejmirtes
force-pushed
the
1.5.x
branch
3 times, most recently
from
ddd20b4
to
95d480b
Compare
This Extension is a copy of "ArrayMergeFunctionDynamicReturnTypeExtension"
⇾ requested here: #622
INFO: Currently we are getting wrong types from "ArrayMergeFunctionDynamicReturnTypeExtension" because PHP handles array-keys different here: https://3v4l.org/YfKYq