added ArrayReplaceFunctionReturnTypeExtension
#1087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clxmstaab
force-pushed
the
array-replace
branch
2 times, most recently
from
74924cf to
8a2800a
Compare
ondrejmirtes
requested changes
Mar 21, 2022
clxmstaab
force-pushed
the
array-replace
branch
from
ab64a59 to
4c892ca
Compare
|
I am unable to open the github action job logs of the 2 errored jobs: see e.g. -> opened a github support ticket |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to built a simpler variant for the
array_replaceextension, which hopefully does not suffer from the perf problems which lead to reverting the first revision.My primary motivation was to cover a
non-empty-arrayreturn type.. if the inference itself is too costly I could reduce the extension to only judge about the non-empty-nessI re-used the tests from #696
closes phpstan/phpstan#5327
closes #696