Fix Throwable::getCode() method return type

[herndlm]

Fixes: phpstan/phpstan#6001

Based on #680 from @akondas.

My contribution here is mostly my stubborness :)

[ondrejmirtes]

Hi, this would be too annoying. In 99 % of cases it returns an int. With this change you'd require people on levels < 9 to suddenly also handle string in places where it can't occur. Although it's nice to do that from type safety perspective, I also often make pragmatic choices.

What I'd accept is this method to return a BenevolentUnionType of int|string. You can't express that in PHPDoc, it'd need dynamic return type extension.

[herndlm]

Hi, this would be too annoying. In 99 % of cases it returns an int. With this change you'd require people on levels < 9 to suddenly also handle string in places where it can't occur. Although it's nice to do that from type safety perspective, I also often make pragmatic choices.

What I'd accept is this method to return a BenevolentUnionType of int|string. You can't express that in PHPDoc, it'd need dynamic return type extension.

Ok thx, I can take a look at that.
Just one thing - I might have misunderstood you, but as it currently is typed with returning mixed wouldn't this change remove some of the annoyances? :)
UPDATE: I definitely misunderstood you, the important part is "< 9" I guess. Well, I'll take a look at the extension then next

[ondrejmirtes]

it currently is typed with returning mixed wouldn't this change remove some of the annoyances? :)

Would you mind to show them as phpstan.org example?

[herndlm]

Would you mind to show them as phpstan.org example?

I was misunderstanding you. The type is mixed, but this is irrelevant in phpstan < 9 as you said, see https://phpstan.org/r/ef5e659e-83ce-4157-8117-5e7d818188ad

So only ”annoying" for level 9 users. Sorry and thx again :)