Fixed unpack - third parameter introduced in 7.1.1 is optional

phpstan · Jan 30, 2017 · 24894eb · 24894eb
1 parent c7582cf
commit 24894eb
Show file tree

Hide file tree

Showing 3 changed files with 44 additions and 0 deletions.
diff --git a/src/Reflection/FunctionReflection.php b/src/Reflection/FunctionReflection.php
@@ -99,6 +99,16 @@ public function getParameters(): array
 					true
 				);
 			}
+			if (
+				$this->reflection->getName() === 'unpack'
+				&& PHP_VERSION_ID >= 70101
+			) {
+				$this->parameters[2] = new DummyParameter(
+					'offset',
+					new IntegerType(false),
+					true
+				);
+			}
 		}
 
 		return $this->parameters;

diff --git a/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php b/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php
@@ -104,4 +104,34 @@ public function testCallToWeirdFunctions()
 		]);
 	}
 
+	/**
+	 * @requires PHP 7.1.1
+	 */
+	public function testUnpackOnAfter711()
+	{
+		$this->analyse([__DIR__ . '/data/unpack.php'], [
+			[
+				'Function unpack invoked with 0 parameters, 2-3 required.',
+				3,
+			],
+		]);
+	}
+
+	public function testUnpackOnBefore711()
+	{
+		if (PHP_VERSION_ID >= 70101) {
+			$this->markTestSkipped('This test requires PHP < 7.1.1');
+		}
+		$this->analyse([__DIR__ . '/data/unpack.php'], [
+			[
+				'Function unpack invoked with 0 parameters, 2 required.',
+				3,
+			],
+			[
+				'Function unpack invoked with 3 parameters, 2 required.',
+				4,
+			],
+		]);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Functions/data/unpack.php b/tests/PHPStan/Rules/Functions/data/unpack.php
@@ -0,0 +1,4 @@
+<?php
+
+unpack();
+unpack($format, $data, 1);