Add a rule to enforce one line only between functions declarations

phpstan · Apr 29, 2019 · 57b8ce3 · 57b8ce3
1 parent 56faa0c
commit 57b8ce3
Show file tree

Hide file tree

Showing 9 changed files with 7 additions and 11 deletions.
diff --git a/phpcs.xml b/phpcs.xml
@@ -58,6 +58,13 @@
 	<rule ref="SlevomatCodingStandard.Namespaces.UselessAlias"/>
 	<rule ref="SlevomatCodingStandard.PHP.UselessSemicolon"/>
 	<rule ref="SlevomatCodingStandard.PHP.UselessParentheses"/>
+	<rule ref="Squiz.WhiteSpace.FunctionSpacing">
+		<properties>
+			<property name="spacing" value="1" />
+			<property name="spacingBeforeFirst" value="1"/>
+			<property name="spacingAfterLast" value="1"/>
+		</properties>
+	</rule>
 	<exclude-pattern>tests/*/data</exclude-pattern>
 	<exclude-pattern>tests/*/traits</exclude-pattern>
 	<exclude-pattern>tests/notAutoloaded</exclude-pattern>

diff --git a/src/Analyser/SpecifiedTypes.php b/src/Analyser/SpecifiedTypes.php
@@ -83,7 +83,6 @@ public function intersectWith(SpecifiedTypes $other): self
 		return new self($sureTypeUnion, $sureNotTypeUnion);
 	}
 
-
 	public function unionWith(SpecifiedTypes $other): self
 	{
 		$sureTypeUnion = $this->sureTypes + $other->sureTypes;

diff --git a/src/PhpDoc/ResolvedPhpDocBlock.php b/src/PhpDoc/ResolvedPhpDocBlock.php
@@ -111,7 +111,6 @@ public static function createEmpty(): self
 		return new self([], [], [], [], null, null, false, false, false);
 	}
 
-
 	/**
 	 * @return array<string|int, \PHPStan\PhpDoc\Tag\VarTag>
 	 */

diff --git a/src/Reflection/SignatureMap/ParameterSignature.php b/src/Reflection/SignatureMap/ParameterSignature.php
@@ -38,7 +38,6 @@ public function __construct(
 		$this->variadic = $variadic;
 	}
 
-
 	public function getName(): string
 	{
 		return $this->name;

diff --git a/src/Rules/Operators/InvalidComparisonOperationRule.php b/src/Rules/Operators/InvalidComparisonOperationRule.php
@@ -24,7 +24,6 @@ public function __construct(RuleLevelHelper $ruleLevelHelper)
 		$this->ruleLevelHelper = $ruleLevelHelper;
 	}
 
-
 	public function getNodeType(): string
 	{
 		return Node\Expr\BinaryOp::class;
@@ -87,7 +86,6 @@ private function isNumberType(Scope $scope, Node\Expr $expr): bool
 		return !$acceptedType->isSuperTypeOf($type)->no();
 	}
 
-
 	private function isObjectType(Scope $scope, Node\Expr $expr): bool
 	{
 		$acceptedType = new ObjectWithoutClassType();

diff --git a/tests/PHPStan/Type/CallableTypeTest.php b/tests/PHPStan/Type/CallableTypeTest.php
@@ -45,7 +45,6 @@ public function testIsSuperTypeOf(CallableType $type, Type $otherType, TrinaryLo
 		);
 	}
 
-
 	public function dataIsSubTypeOf(): array
 	{
 		return [

diff --git a/tests/PHPStan/Type/Constant/ConstantArrayTypeTest.php b/tests/PHPStan/Type/Constant/ConstantArrayTypeTest.php
@@ -70,7 +70,6 @@ public function dataAccepts(): iterable
 		];
 	}
 
-
 	/**
 	 * @dataProvider dataAccepts
 	 * @param ConstantArrayType $type
@@ -87,7 +86,6 @@ public function testAccepts(ConstantArrayType $type, Type $otherType, TrinaryLog
 		);
 	}
 
-
 	public function dataIsSuperTypeOf(): iterable
 	{
 		yield [

diff --git a/tests/PHPStan/Type/Constant/ConstantIntegerTypeTest.php b/tests/PHPStan/Type/Constant/ConstantIntegerTypeTest.php
@@ -31,7 +31,6 @@ public function dataAccepts(): iterable
 		];
 	}
 
-
 	/**
 	 * @dataProvider dataAccepts
 	 * @param ConstantIntegerType $type
@@ -48,7 +47,6 @@ public function testAccepts(ConstantIntegerType $type, Type $otherType, TrinaryL
 		);
 	}
 
-
 	public function dataIsSuperTypeOf(): iterable
 	{
 		yield [

diff --git a/tests/PHPStan/Type/IntegerTypeTest.php b/tests/PHPStan/Type/IntegerTypeTest.php
@@ -20,7 +20,6 @@ public function testAccepts(): void
 		$this->assertTrue($integerType->accepts(new StringType(), true)->no());
 	}
 
-
 	public function dataIsSuperTypeOf(): iterable
 	{
 		yield [