Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.11.2 -> 0.11.3 : "result of || is always true" #1966

Closed
Minishlink opened this issue Mar 11, 2019 · 1 comment
Closed

0.11.2 -> 0.11.3 : "result of || is always true" #1966

Minishlink opened this issue Mar 11, 2019 · 1 comment

Comments

@Minishlink
Copy link

Hello,

Summary of a problem or a feature request

This line triggers result of || is always true on 0.11.3 but not on 0.11.2. (see Travis job)
This could be linked to issue #1377
It looks like this happens when there is two || in a condition.

Code snippet that reproduces the problem

https://phpstan.org/r/063396b9-c2a4-46fa-9b73-777c46503ab2

Expected output

PHPStan shouldn't report any error. Or I may be wrong somewhere?
Minishlink added a commit to web-push-libs/web-push-php that referenced this issue Mar 11, 2019
@Minishlink
Force PHPStan version
0f611f8 
See phpstan/phpstan#1966
@ondrejmirtes
Copy link
Member

Fixed, thanks! d0da752

marcvdm pushed a commit to level23/web-push-php that referenced this issue Jun 14, 2019
@Minishlink @marcvdm
Force PHPStan version
4c0c20b 
See phpstan/phpstan#1966
marcvdm pushed a commit to level23/web-push-php that referenced this issue Jun 14, 2019
@Minishlink @marcvdm
Force PHPStan version
09b74c1 
See phpstan/phpstan#1966
@lock lock bot locked as resolved and limited conversation to collaborators Dec 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Minishlink @ondrejmirtes