Match expression does not handle remaining value with an array value #4451

jkuchar · 2021-01-28T14:12:33Z

Bug report

match() definitely handles all values, but phpstan do not think so.

Code snippet that reproduces the problem

https://phpstan.org/r/b07c57ab-5084-4149-9c8b-21c1e14d2377

Expected output

No error.

The text was updated successfully, but these errors were encountered:

phpstan-bot · 2021-09-23T08:39:23Z

@jkuchar After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
 PHP 8.0 (1 error)
 ==========
 
- 9: Match expression does not handle remaining value: array(bool, bool)
+-1: Internal error: PHPStan\Rules\Methods\WrongCaseOfInheritedMethodRule::findMethod(): Argument #2 ($classReflection) must be of type PHPStan\Reflection\ClassReflection, null given, called in /var/task/vendor/phpstan/phpstan-strict-rules/src/Rules/Methods/WrongCaseOfInheritedMethodRule.php on line 40
+Run PHPStan with --debug option and post the stack trace to:
+https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md
 
 PHP 7.4 (4 errors)
 ==========

Full report

PHP 8.0 (1 error)

Line	Error
-1	`Internal error: PHPStan\Rules\Methods\WrongCaseOfInheritedMethodRule::findMethod(): Argument #2 ($classReflection) must be of type PHPStan\Reflection\ClassReflection, null given, called in /var/task/vendor/phpstan/phpstan-strict-rules/src/Rules/Methods/WrongCaseOfInheritedMethodRule.php on line 40Run PHPStan with --debug option and post the stack trace to:https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md`

PHP 7.4 (4 errors)

Line	Error
10	`Syntax error, unexpected T_DOUBLE_ARROW on line 10`
11	`Syntax error, unexpected T_DOUBLE_ARROW on line 11`
12	`Syntax error, unexpected T_DOUBLE_ARROW on line 12`
13	`Syntax error, unexpected T_DOUBLE_ARROW on line 13`

PHP 7.1 – 7.3 (5 errors)

Line	Error
7	`Syntax error, unexpected ':' on line 7`
10	`Syntax error, unexpected T_DOUBLE_ARROW on line 10`
11	`Syntax error, unexpected T_DOUBLE_ARROW on line 11`
12	`Syntax error, unexpected T_DOUBLE_ARROW on line 12`
13	`Syntax error, unexpected T_DOUBLE_ARROW on line 13`

phpstan-bot · 2021-10-04T21:34:35Z

@jkuchar After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
 PHP 8.0 (1 error)
 ==========
 
- 9: Match expression does not handle remaining value: array(bool, bool)
+ 5: Method HelloWorld::sayHello() should return int but return statement is missing.
 
 PHP 7.4 (4 errors)
 ==========

Full report

PHP 8.0 (1 error)

Line	Error
5	`Method HelloWorld::sayHello() should return int but return statement is missing.`

PHP 7.4 (4 errors)

Line	Error
10	`Syntax error, unexpected T_DOUBLE_ARROW on line 10`
11	`Syntax error, unexpected T_DOUBLE_ARROW on line 11`
12	`Syntax error, unexpected T_DOUBLE_ARROW on line 12`
13	`Syntax error, unexpected T_DOUBLE_ARROW on line 13`

PHP 7.1 – 7.3 (5 errors)

Line	Error
7	`Syntax error, unexpected ':' on line 7`
10	`Syntax error, unexpected T_DOUBLE_ARROW on line 10`
11	`Syntax error, unexpected T_DOUBLE_ARROW on line 11`
12	`Syntax error, unexpected T_DOUBLE_ARROW on line 12`
13	`Syntax error, unexpected T_DOUBLE_ARROW on line 13`

solverat · 2021-10-11T17:31:27Z

same goes for string:

$value *= match ($identifier) {
  'g', 'm', 'k' => 1024,
};

https://phpstan.org/r/37736108-b211-4406-a94e-cec1e5b14c18

ondrejmirtes · 2021-10-11T21:15:22Z

@solverat Your issue is unrelated, and the reported error is legit. If someone passes 'a' into your method, the match expression will throw an exception. You can either handle all possible strings, or use advanced types in PHPDocs: https://phpstan.org/writing-php-code/phpdoc-types#literals-and-constants

solverat · 2021-10-12T06:55:36Z

@ondrejmirtes damn you're right - I guess I misinterpreted the message then. Thanks for clarifying!

phpstan-bot · 2021-10-13T17:09:18Z

@jkuchar After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
 PHP 8.0 (1 error)
 ==========
 
- 9: Match expression does not handle remaining value: array(bool, bool)
+ 9: Match expression does not handle remaining value: array{bool, bool}
 
 PHP 7.4 (4 errors)
 ==========

Full report

PHP 8.0 (1 error)

Line	Error
9	`Match expression does not handle remaining value: array{bool, bool}`

PHP 7.4 (4 errors)

Line	Error
10	`Syntax error, unexpected T_DOUBLE_ARROW on line 10`
11	`Syntax error, unexpected T_DOUBLE_ARROW on line 11`
12	`Syntax error, unexpected T_DOUBLE_ARROW on line 12`
13	`Syntax error, unexpected T_DOUBLE_ARROW on line 13`

PHP 7.1 – 7.3 (5 errors)

Line	Error
7	`Syntax error, unexpected ':' on line 7`
10	`Syntax error, unexpected T_DOUBLE_ARROW on line 10`
11	`Syntax error, unexpected T_DOUBLE_ARROW on line 11`
12	`Syntax error, unexpected T_DOUBLE_ARROW on line 12`
13	`Syntax error, unexpected T_DOUBLE_ARROW on line 13`

da-mask · 2022-05-11T02:45:22Z

For those who come from google, you probably just want to add a default arm to your match expression.

eexit · 2022-06-07T12:53:55Z

AFAIK, the default pattern is not mandatory so PHPStan should allow expressions when it's missing.

allan-simon · 2022-06-07T12:59:34Z

AFAIK, the default pattern is not mandatory so PHPStan should allow expressions when it's missing.

exactly currently we have to do this

        default => throw new UnhandledMatchError($type),

to please phpstan while keeping the default (no pun intended) behaviour

mostafa-rz · 2022-06-08T13:30:40Z

same for spaceship operator

return match ($foo <=> $bar) {
            1 => TrendEnum::UP,
            0 => TrendEnum::NEUTRAL,
            -1 => TrendEnum::DOWN,
        };

https://phpstan.org/r/71c1b6b0-cab7-49e4-8f3a-813900ba68e4

phpstan-bot · 2022-06-09T15:37:30Z

@mostafa-rz After the latest commit in 1.7.x, PHPStan now reports different result with your code snippet:

@@ @@
-PHP 8.1 (1 error)
+PHP 8.1
 ==========
 
-16: Match expression does not handle remaining value: int<-1, 1>
+No errors
 
 PHP 7.1 – 8.0 (2 errors)
 ==========

Full report

PHP 8.1

No errors

PHP 7.1 – 8.0 (2 errors)

Line	Error
2	`Syntax error, unexpected T_STRING on line 2`
4	`Syntax error, unexpected T_CASE on line 4`

SomeBdyElse · 2022-10-26T11:36:08Z

I agree with #4451 (comment) that it should be possible to use the default "\UnhandeledMatchError" without explicitly adding a default case.

ondrejmirtes · 2022-10-26T11:38:40Z

@SomeBdyElse There's a feature request about this: #8042 (it has a hint on how to implement it)

jaroslavtyc · 2023-02-27T17:05:56Z

What about this

            $propertyValue = match ($property) {
                ReceiveOperation::OPERATION_ID => $value->getOperationId(),
                ReceiveOperation::OPERATION_CODE => $value->getOperationCode(),
                ReceiveOperation::DATA => $value->getData(),
                'default' => throw new \LogicException('Unknown property ' . var_export($property, true)),
            };

  Line   Api/Validation/ConstraintReceiveOperationValidator.php   
 ------ --------------------------------------------------------- 
  28     Match expression does not handle remaining value: mixed

Is it intended?

PHPStan - PHP Static Analysis Tool 1.10.3

ondrejmirtes · 2023-02-27T17:08:24Z

@jaroslavtyc Please reproduce your problem on phpstan.org/try and open a separate issue.

jaroslavtyc · 2023-02-27T18:25:21Z

@jaroslavtyc Please reproduce your problem on phpstan.org/try and open a separate issue.

#8969

phpstan-bot · 2023-05-23T14:53:18Z

@mostafa-rz After the latest push in 1.11.x, PHPStan now reports different result with your code snippet:

@@ @@
-PHP 8.1 (1 error)
+PHP 8.1 (3 errors)
 ==========
 
-16: Match expression does not handle remaining value: int<-1, 1>
+ 4: Enum case TrendEnum::UP without type doesn't match the "string" type.
+ 5: Enum case TrendEnum::NEUTRAL without type doesn't match the "string" type.
+ 6: Enum case TrendEnum::DOWN without type doesn't match the "string" type.
 
 PHP 7.1 – 8.0 (2 errors)
 ==========

Full report

PHP 8.1 (3 errors)

Line	Error
4	`Enum case TrendEnum::UP without type doesn't match the "string" type.`
5	`Enum case TrendEnum::NEUTRAL without type doesn't match the "string" type.`
6	`Enum case TrendEnum::DOWN without type doesn't match the "string" type.`

PHP 7.1 – 8.0 (2 errors)

Line	Error
2	`Syntax error, unexpected T_STRING on line 2`
4	`Syntax error, unexpected T_CASE on line 4`

phpstan-bot · 2023-05-29T13:42:10Z

@mostafa-rz After the latest push in 1.11.x, PHPStan now reports different result with your code snippet:

@@ @@
-PHP 8.1 (1 error)
+PHP 8.1 (3 errors)
 ==========
 
-16: Match expression does not handle remaining value: int<-1, 1>
+ 4: Enum case TrendEnum::UP does not have a value but the enum is backed with the "string" type.
+ 5: Enum case TrendEnum::NEUTRAL does not have a value but the enum is backed with the "string" type.
+ 6: Enum case TrendEnum::DOWN does not have a value but the enum is backed with the "string" type.
 
 PHP 7.1 – 8.0 (2 errors)
 ==========

Full report

PHP 8.1 (3 errors)

Line	Error
4	`Enum case TrendEnum::UP does not have a value but the enum is backed with the "string" type.`
5	`Enum case TrendEnum::NEUTRAL does not have a value but the enum is backed with the "string" type.`
6	`Enum case TrendEnum::DOWN does not have a value but the enum is backed with the "string" type.`

PHP 7.1 – 8.0 (2 errors)

Line	Error
2	`Syntax error, unexpected T_STRING on line 2`
4	`Syntax error, unexpected T_CASE on line 4`

homersimpsons · 2023-05-29T15:44:44Z

Note that this is now fixed for the spaceship operator with a correct syntax: https://phpstan.org/r/200e398c-d2a5-4370-aaf9-2cfa6864a409

<?php declare(strict_types = 1);
enum TrendEnum
{
    case UP;
    case NEUTRAL;
    case DOWN;
}

class HelloWorld
{
	public function sayHello(): mixed
	{
		$foo = fn(): int => rand();
		$bar = fn(): int => rand();

		return match ($foo <=> $bar) {
                    1 => TrendEnum::UP,
                    0 => TrendEnum::NEUTRAL,
                   -1 => TrendEnum::DOWN,
              };
	}
}

Commenting one match-arm also lead to the expected result. I think this can be closed.

But the array of bool still is not handled.

<?php declare(strict_types = 1);

class HelloWorld
{
	public function sayHello(): int
	{
		$verified = fn(): bool => rand() === 1;
		
		return match([$verified(), $verified()]) {
			[true, true] => 1,
			[true, false] => 2,
			[false, true] => 3,
			[false, false] => 4,
		};
		
	}
}

bwaidelich · 2023-06-19T11:20:50Z

Is this related: https://phpstan.org/r/0c53d9eb-f719-480a-9fa6-6d8fbaf3546e ?

ondrejmirtes · 2023-06-19T11:41:05Z

@bwaidelich No, your code would be correct only if those classes were final.

bwaidelich · 2023-06-19T11:43:30Z

your code would be correct only if those classes were final.

Oh, of course.. https://phpstan.org/r/10db3101-89fa-44dd-92c1-682fe650f865
You're the man!

ondrejmirtes · 2023-06-19T12:56:48Z

This was possible to solve thanks to: phpstan/phpstan-src@7912caf

I realized that [bool, bool] is in fact [true, true]|[true, false]|[false, true]|[false, false]. So I wrote Type::getFiniteTypes() to generate these combinations.

After that I took advantage of the new method when removing types: phpstan/phpstan-src@b5cf52b

And finally I made it work inside match condition: phpstan/phpstan-src@0cdda0b

github-actions · 2023-07-21T00:00:54Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

ondrejmirtes added the bug label Jan 28, 2021

rvanvelzen mentioned this issue Jun 9, 2022

Fix incorrect UnhandledMatchError for match expressions using spaceship operator phpstan/phpstan-src#1408

Merged

web-fu mentioned this issue Dec 30, 2022

Match expression against gettype does not work as expected #8614

Closed

Neirda24 mentioned this issue Apr 3, 2023

Trying to remove false positive on logical or. infection/infection#1801

Merged

2 tasks

phpstan-bot closed this as completed in phpstan/phpstan-src@0cdda0b Jun 19, 2023

github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2023

Match expression does not handle remaining value with an array value #4451

Match expression does not handle remaining value with an array value #4451

Comments

jkuchar commented Jan 28, 2021

Bug report

Code snippet that reproduces the problem

Expected output

phpstan-bot commented Sep 23, 2021

PHP 8.0 (1 error)

PHP 7.4 (4 errors)

PHP 7.1 – 7.3 (5 errors)

phpstan-bot commented Oct 4, 2021

PHP 8.0 (1 error)

PHP 7.4 (4 errors)

PHP 7.1 – 7.3 (5 errors)

solverat commented Oct 11, 2021

ondrejmirtes commented Oct 11, 2021

solverat commented Oct 12, 2021 • edited

phpstan-bot commented Oct 13, 2021

PHP 8.0 (1 error)

PHP 7.4 (4 errors)

PHP 7.1 – 7.3 (5 errors)

da-mask commented May 11, 2022

eexit commented Jun 7, 2022

allan-simon commented Jun 7, 2022

mostafa-rz commented Jun 8, 2022

phpstan-bot commented Jun 9, 2022

PHP 8.1

PHP 7.1 – 8.0 (2 errors)

SomeBdyElse commented Oct 26, 2022

ondrejmirtes commented Oct 26, 2022

jaroslavtyc commented Feb 27, 2023 • edited

ondrejmirtes commented Feb 27, 2023

jaroslavtyc commented Feb 27, 2023

phpstan-bot commented May 23, 2023

PHP 8.1 (3 errors)

PHP 7.1 – 8.0 (2 errors)

phpstan-bot commented May 29, 2023

PHP 8.1 (3 errors)

PHP 7.1 – 8.0 (2 errors)

homersimpsons commented May 29, 2023 • edited

bwaidelich commented Jun 19, 2023

ondrejmirtes commented Jun 19, 2023

bwaidelich commented Jun 19, 2023

ondrejmirtes commented Jun 19, 2023

github-actions bot commented Jul 21, 2023

solverat commented Oct 12, 2021 •

edited

jaroslavtyc commented Feb 27, 2023 •

edited

homersimpsons commented May 29, 2023 •

edited