Fix incorrect UnhandledMatchError for match expressions using spaceship operator #1408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
reviewed
Jun 9, 2022
| @@ -661,6 +661,11 @@ private function resolveType(Expr $node): Type | |||
| return new NeverType(true); | |||
| } | |||
|
|
|||
| $exprString = $this->getNodeKey($node); | |||
| if (isset($this->moreSpecificTypes[$exprString]) && $this->moreSpecificTypes[$exprString]->getCertainty()->yes()) { | |||
| return $this->moreSpecificTypes[$exprString]->getType(); | |||
There was a problem hiding this comment.
It's an obvious solution but it's gonna be slow :(
There was a problem hiding this comment.
I didn't notice a slowdown - running make phpstan actually seems slightly faster 😅
There was a problem hiding this comment.
Alright, I'll benchmark it :)
|
I profiled it and it's not slower 🎉 I even came up with an idea for a small optimization which I'm gonna try soon. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See phpstan/phpstan#4451 (comment)