Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable extensions not running with 1.9.x anymore #8720

Closed
wants to merge 1 commit into from

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented Jan 17, 2023

similar as 3e10ce4

the idea is to make 1.9.x PRs green again, e.g. phpstan/phpstan-src#2146

an alternative to this approach might be to lock extensions to an old commit maybe that is still compatible with 1.9.x? in the matrix this could be something like phpstan-strict-rules:<commit-hash> or so..

@ondrejmirtes
Copy link
Member

 lock extensions to an old commit

Yes, that's what I'd like to do this time :) Thanks. We need to introduce a new env variable/argument going into test-extensions.sh.

@herndlm
Copy link
Contributor Author

herndlm commented Jan 17, 2023

Yes, that's what I'd like to do this time :) Thanks. We need to introduce a new env variable/argument going into test-extensions.sh.

I'm already working on it, I'm bad with github actions though, which I'm currently completely ignoring. What do you think of my initially mentioned format? I can do the rest in test-extensions.sh then. Or is there a better way to configure this in the matrix?

@herndlm herndlm closed this Jan 17, 2023
@herndlm herndlm deleted the disable-extension-tests branch January 17, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants