-
-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock extensions for 1.9.x #8721
Conversation
most likely the doctrine extension will be unhappy again as in https://github.com/phpstan/phpstan/actions/runs/3941059209/jobs/6742978552
I assume you know more about that one? |
Yeah apparently you need to update what's excluded a few lines below, because there's: |
YOLO :) Thank you. |
yeah, the excludes is a bit ugly, but it seems to be working fine :) |
should I duplicate the shell script changes in 1.10.x? |
Yes please :) in phpstan-src 1.9.x is automatically merged into 1.10.x but in phpstan/phpstan, it doesn't make sense to do that. |
as mentioned in #8720
something simple like this maybe 😅 let's see..