Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock extensions for 1.9.x #8721

Merged
merged 4 commits into from
Jan 17, 2023
Merged

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented Jan 17, 2023

as mentioned in #8720

something simple like this maybe 😅 let's see..

@herndlm
Copy link
Contributor Author

herndlm commented Jan 17, 2023

most likely the doctrine extension will be unhappy again as in https://github.com/phpstan/phpstan/actions/runs/3941059209/jobs/6742978552

Error: Class Doctrine\DBAL\Platforms\MySqlPlatform referenced with incorrect case: Doctrine\DBAL\Platforms\MySQLPlatform.
 ------ ----------------------------------------------------------------------- 
  Line   src/Doctrine/Mapping/ClassMetadataFactory.php                          
 ------ ----------------------------------------------------------------------- 
  49     Class Doctrine\DBAL\Platforms\MySqlPlatform referenced with incorrect  
         case: Doctrine\DBAL\Platforms\MySQLPlatform.                           
 ------ ----------------------------------------------------------------------- 

I assume you know more about that one?

@ondrejmirtes
Copy link
Member

Yeah apparently you need to update what's excluded a few lines below, because there's: extension-name: "phpstan-doctrine" without the hash

@ondrejmirtes
Copy link
Member

YOLO :) Thank you.

@ondrejmirtes ondrejmirtes merged commit a9fd9ff into phpstan:1.9.x Jan 17, 2023
@herndlm
Copy link
Contributor Author

herndlm commented Jan 17, 2023

yeah, the excludes is a bit ugly, but it seems to be working fine :)

@herndlm herndlm deleted the lock-old-extensions branch January 17, 2023 16:27
@herndlm
Copy link
Contributor Author

herndlm commented Jan 17, 2023

should I duplicate the shell script changes in 1.10.x?

@ondrejmirtes
Copy link
Member

Yes please :) in phpstan-src 1.9.x is automatically merged into 1.10.x but in phpstan/phpstan, it doesn't make sense to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants