BUG Show actual stacktrace for errors / exceptions #20
Conversation
| 'formatted' => $record['formatted'], | ||
| 'channel' => $record['channel'], | ||
| { | ||
| $record = array_merge($record, [ |
There was a problem hiding this comment.
added array_merge here to prevent other $record keys getting lost forever.
| if (!empty($record['stack'])) { | ||
| $stack = (bool) $record['stack']; | ||
| if (!empty($record['stacktrace'])) { | ||
| $stack = $record['stacktrace']; |
There was a problem hiding this comment.
Use actual trace array instead of bool to prevent sentry re-generating trace incorrectly.
There was a problem hiding this comment.
I dislike multi-type parameters intensely. If Raven::captureMessage() wants to accept an empty param for its 4th arg, it should allow an empty array....but then it goes on to accept $stack as null in Raven::capture() so what can you do...
I don't recall specifically why I cast to a bool, but it could be related to Raven_Client:909:
...
if ((!$stack && $this->auto_log_stacks) || $stack === true) {
$stack = debug_backtrace();
...
There was a problem hiding this comment.
If you cast it as a bool, it forces the stacktrace to be generated internally.
If you pass an array, it uses that value as the actual stacktrace.
The problem is that monolog stores the stacktrace for later error reporting (register_shutdown_function), so it's useless to try to use debug_backtrace in the capture since you are no longer in the stack.
I think false is just no stacktrace.
src/Handler/SentryMonologHandler.php
Outdated
| /** | ||
| * @var SentryClientAdaptor | ||
| */ | ||
| protected $client; | ||
|
|
||
| /** | ||
| * @param int $level | ||
| * @param bool $bubble |
There was a problem hiding this comment.
Which linting tool / ruleset are you using? I rather like vertically aligned param descriptions.
There was a problem hiding this comment.
PHPStorm auto-format, sorry. I can undo if you like.
There was a problem hiding this comment.
in Editor > Code Style > PHP
I've turned this on. :)
| * | ||
| * @param Member $member | ||
| * | ||
| * @param Member $member |
There was a problem hiding this comment.
How is this @phptek ?
|
@phptek I've done a linting review, fixed a few type hints, fixed a bug in RavenClient::getLevel(), and fixed the indentation based on your preference. How does it look now? |
|
Merged. Many thanks @tractorcow |
|
Yay, thanks to you! Now I feel bad about letting my PRs sit around for months when you have a same day turnaround, haha. |
|
LOL. I have standards to maintain seeing as PRs taking too long was the reason I built phptek/sentry instead of pushing PRs to the incumbent's Sentry module. |
|
@phptek can we please have a new release to include this fix? thanks. |
@phptek Sentry had been only ever rendering stack traces for the error handling classes themselves; These are not so useful when trying to diagnose the actual issue. :)
Tested on both fatal errors, as well as exceptions.
Uses the work I did at Seldaek/monolog#1080 to capture non-exception traces as well. :)