Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php_v8js_v8_has_property unimplemented. #32

Closed
cscott opened this issue Sep 30, 2013 · 4 comments
Closed

php_v8js_v8_has_property unimplemented. #32

cscott opened this issue Sep 30, 2013 · 4 comments

Comments

@cscott
Copy link
Collaborator

cscott commented Sep 30, 2013

Shouldn't be hard to write, but there's a // Not implemented yet comment in v8js.cc.

I ran into this while trying to use PHP's property_exists method on an object returned to PHP from JavaScript.
@satoshi75nakamoto
Copy link
Contributor

@cscott — Are you going to try and work on this? Just curious.

@cscott
Copy link
Collaborator Author

cscott commented Oct 3, 2013

I might. I'm trying to get the other bits of my v8js-using application hacked together first, but I have the PHP Zend extension docs loaded up in a tab for whenever I get an itch to have a go at it.

@satoshi75nakamoto
Copy link
Contributor

Okay cool thanks for the update @cscott.

cscott added a commit to cscott/v8js that referenced this issue Oct 5, 2013
@cscott
Implement property_exists()/isset()/empty() on wrapped JavaScript obj…
035e6fa 
…ects.

Fixes issue phpv8#32.
@cscott cscott mentioned this issue Oct 5, 2013
Merged
@satoshi75nakamoto
Copy link
Contributor

This is now fixed by @cscott's commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@satoshi75nakamoto @cscott