Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kill timeout documentation #517

Closed
jarischaefer opened this issue Oct 16, 2018 · 3 comments · Fixed by #519
Closed

Update kill timeout documentation #517

jarischaefer opened this issue Oct 16, 2018 · 3 comments · Fixed by #519
Assignees
Milestone

Comments

@jarischaefer
Copy link
Contributor

The documentation should be updated to explain the increased kill timeout (see PR 510).

From CONTRIBUTING.md

The master branch is supposed to point to the latest stable release, because users read documentation from the master branch.

Should we update the documentation on the master branch despite the fact that the current release does not yet reflect the changes made in master? Perhaps a disclaimer should be added (e.g. "This change is only available on 0.11.1+").

@kingdonb
Copy link
Collaborator

Maybe something under the heading:
https://github.com/phusion/baseimage-docker/#shutting-down-your-process

Like, "Prior to 0.11.1, the default value for KILL_PROCESS_TIMEOUT was 5 seconds. In version 0.11.1+ the default process timeout has been adjusted to 30 seconds."

Since it was always a user-configurable setting, I don't think language like "only available" makes sense. (Opening a PR for this)

kingdonb pushed a commit to kingdonb/baseimage-docker that referenced this issue Oct 21, 2018
@kingdonb
Copy link
Collaborator

How does that look

@jarischaefer
Copy link
Contributor Author

Looks good to me

@Theaxiom Theaxiom added this to the 0.11.1 milestone Oct 23, 2018
@kingdonb kingdonb self-assigned this Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants