Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the ability to specify a PCRE source directory when running 'passenger-install-nginx-module'. #24

Closed
wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 7, 2011

Adding the ability to specify a PCRE source directory when running 'passenger-install-nginx-module'. Fixes #698 "passenger-install-nginx-module should install without internet access".

http://code.google.com/p/phusion-passenger/issues/detail?id=698

Adding the ability to specify a PCRE source directory when running
'passenger-install-nginx-module'.
@dmitry
Copy link

dmitry commented Dec 20, 2011

+1

2 similar comments
@SvetlanaZinchenko
Copy link

+1

@matiasow
Copy link

matiasow commented Feb 8, 2012

+1

@FooBarWidget
Copy link
Member

Hi ghost. My apologies for not responding earlier. Your patch looks good though I have one comment:

STDERR.puts "You cannot specify both --auto-download and --nginx-source-dir or --pcre-source-dir."

It's unclear whether you mean --auto-download and (--nginx-source-dir or --pcre-source-dir) or (--auto-download and --nginx-source-dir) or --pcre-source-dir

Also, we require contributors to sign a contributor agreement before we can merge their patches.

@guigs
Copy link

guigs commented Jan 25, 2015

+1

@OnixGH
Copy link
Contributor

OnixGH commented Apr 1, 2015

@ghost it's been a while but we'd still like to incorporate your pull request! Would you sign the http://www.phusion.nl/forms/contributor_agreement to make this possible?

@OnixGH
Copy link
Contributor

OnixGH commented May 6, 2015

User account no longer available, can't merge without signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants