Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.9's Split into Two Modules Breaks JPMS Usage #80

Closed
A248 opened this issue Jan 26, 2021 · 6 comments
Closed

2.9's Split into Two Modules Breaks JPMS Usage #80

A248 opened this issue Jan 26, 2021 · 6 comments
Assignees
Labels

Comments

@A248
Copy link
Contributor

A248 commented Jan 26, 2021

Version 2.9 seems to have introduced an issue when using Argon2 in a modular project. This causes compilation of a dependent project to fail, where the dependent project uses module-info.

The problem is that there are 2 artifacts with de.mkammerer.argon2 as a module name.

My IDE notes 'ambiguous module name' for de.mkammerer.argon2. Based on the argon2-jvm build setup with gradle, I suspected both the argon2-jvm and argon2-jvm-nolibs had the same module name. Indeed, opening up the MANIFEST.MF in both jars shows the Automatic-Module-Name is the same.

The only workaround is to downgrade to 2.8. Trying to exclude argon2-jvm-nolibs as a workaround does not work because the packages cannot be found in that case.

@phxql phxql self-assigned this Jan 27, 2021
@phxql
Copy link
Owner

phxql commented Jan 27, 2021

Thanks for finding that. I'll fix it in 2.10 by setting the Automatic-Module-Name to something different in the -nolibs version.

@phxql phxql added the bug label Jan 27, 2021
phxql added a commit that referenced this issue Jan 28, 2021
@phxql
Copy link
Owner

phxql commented Jan 30, 2021

Just released 2.9.1, which fixes this issue.

@phxql phxql closed this as completed Jan 30, 2021
@1tchy
Copy link

1tchy commented Mar 21, 2021

Unfortunately, this is still not fixed. Because - in de.mkammerer.argon2-nolibs is not a valid character in a module name.

But by the way: Thanks for maintaing this repository!

@phxql
Copy link
Owner

phxql commented Mar 22, 2021

Thanks for letting me know, i'll fix that.

@phxql phxql reopened this Mar 22, 2021
phxql added a commit that referenced this issue Mar 22, 2021
It's now `de.mkammerer.argon2.nolibs`
@phxql
Copy link
Owner

phxql commented Mar 22, 2021

It's now de.mkammerer.argon2.nolibs - and i have tested it with a modularized runner :) The next released version will contain the fix.

@phxql
Copy link
Owner

phxql commented Apr 6, 2021

Fix is released in >= 2.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants