Skip to content

Commit

Permalink
Fix for ST2 crash (closes #9; thanks jareciog!)
Browse files Browse the repository at this point in the history
  • Loading branch information
Daniel Shannon committed Jan 7, 2014
1 parent c08abac commit 86a6643
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
4 changes: 2 additions & 2 deletions README.mdown
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ If the output file is not a type that Sublime can open, setting `prevent_viewing
If you have any difficulties with or suggestions for Pandown, please don't hesitate to get in touch. You can use the GitHub "Issues" interface, or send an e-mail to Daniel at `d at daniel dot sh`.

## Thanks and Credits
The bare bones of the code were originally a modification of [Pandoc (Markdown)](https://github.com/jclement/SublimePandoc); though not much of what was there has survived, I'm grateful for the springboard. Almost all of the process-management code is from the `Defaults/exec.py` module. The package includes Gerald Storer's `minify_json` module, which is distributed under the MIT license and is obtainable [here](https://github.com/getify/JSON.minify). Thanks to Gerald for working around Python's (and Douglas Crockford's) obdurate refusal to allow comments in JSON. I'm grateful to the [Critic Markup][critic] project for allowing me to integrate their work into this package. [Brett Terpstra](http://brettterpstra.com)'s generous permission to include his CSS with this package is appreciated above all.
The bare bones of the code were originally a modification of [Pandoc (Markdown)](https://github.com/jclement/SublimePandoc); though not much of what was there has survived, I'm grateful for the springboard. Almost all of the process-management code is from the `Defaults/exec.py` module. The package includes Gerald Storer's `minify_json` module, which is distributed under the MIT license and is obtainable [here](https://github.com/getify/JSON.minify). Thanks to Gerald for working around Python's (and Douglas Crockford's) obdurate refusal to allow comments in JSON. I'm grateful to the [Critic Markup][critic] project for allowing me to integrate their work into this package. Github user [jareciog](https://github.com/jareciog) deserves a special high-five for catching a catastrophic bug under ST2. [Brett Terpstra](http://brettterpstra.com)'s generous permission to include his CSS with this package is appreciated above all.



Expand All @@ -58,4 +58,4 @@ The bare bones of the code were originally a modification of [Pandoc (Markdown)]
[pandoc]: http://johnmacfarlane.net/pandoc/ "Pandoc Home"
[markdown]: http://daringfireball.net/projects/markdown/ "Daring Fireball: Markdown"
[documentation]: http://johnmacfarlane.net/pandoc/README.html "Pandoc: README"
[critic]: http://criticmarkup.com "Critic Markup"
[critic]: http://criticmarkup.com "Critic Markup"
3 changes: 3 additions & 0 deletions changelog.mdown
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
## Notes
As of March 2013, Pandown is _fully compatible with Sublime Text 2 and Sublime Text 3_. "Pandown3" was ported back to ST2, bringing benefits to stability and performance, compatibility with Pandoc versions higher than 1.10, and dual-compatibility, in one Github repository and one project, with the two most recent versions of Sublime. "Pandown3" will no longer be supported; any changes and improvements made will be to the single repository available at <https://github.com/phyllisstein/Pandown>. The stable version is being assigned the number 2.0, and was completed on 25 March 2013.

## Bug Fix---01/07/2014
Thanks to Github user [jareciog](https://github.com/jareciog)'s keen eyes, a crash under ST2 has been fixed.

## Changes and Improvements---08/17/13
* Regressions in last version that went unnoticed till I installed a fresh ST3 should be corrected.

Expand Down
2 changes: 1 addition & 1 deletion pandownBuildCommand.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def run(self, pandoc_from="", pandoc_to=["", ""], do_open=False, prevent_viewing
def checkPandoc(self, env):
cmd = ['pandoc', '--version']
try:
output = subprocess.check_call(cmd, env=env, shell=True)
output = subprocess.check_call(cmd, env=env, shell=False)
except Exception as e:
err("Exception: " + str(e))
return False
Expand Down

1 comment on commit 86a6643

@rkjohnson
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix broke operation for me with ST2 under Windows. I would get this error:

[Pandown: Exception: [Error 2] The system cannot find the file specified]
error: Pandown requires Pandoc

Reverting this fixed my issue.

Please sign in to comment.