Improvements made in response to JOSS reviewer suggestions #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav
force-pushed
the
improvements-from-joss-review
branch
from
2c6d2e3
to
d886078
Compare
Might be useful if the reader doesn't know much about the Maven system.
Includes note about JAVA_HOME environment variable as per #81.
gaurav
force-pushed
the
improvements-from-joss-review
branch
from
d886078
to
783dbc2
Compare
The latter package seems to be more specific, and appears to cover everything we need.
This prevents overlapping class warnings from shaded JARs (https://stackoverflow.com/a/11015175/27310).
This was referenced Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR collects improvements made in response to JOSS reviewer suggestions. This includes:
JAVA_HOMEenvironment variable. Closes Need to set JAVA_HOME to build jphyloref #81.