Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements made in response to JOSS reviewer suggestions #84

Merged
merged 8 commits into from
Jul 7, 2021
Merged

Improvements made in response to JOSS reviewer suggestions #84

merged 8 commits into from
Jul 7, 2021

Commits on Jun 17, 2021

  1. Clarify README: the webserver does not serve content at /.

    @gaurav
    gaurav committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    b34c9dc View commit details
    Browse the repository at this point in the history

  2. Added a separate note on running just the test suite. 

    Might be useful if the reader doesn't know much about the Maven system.
    @gaurav
    gaurav committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    683e3f2 View commit details
    Browse the repository at this point in the history

  3. Added some Java installation instructions. 

    Includes note about JAVA_HOME environment variable as per #81.
    @gaurav
    gaurav committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    783dbc2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into improvements-from-joss-review

    @gaurav
    gaurav committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    f93568e View commit details
    Browse the repository at this point in the history

  5. Removed unused JSONLD package.

    @gaurav
    gaurav committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    1525a2e View commit details
    Browse the repository at this point in the history

  6. Replaced owlapi-distribution with owlapi-apibinding. 

    The latter package seems to be more specific, and appears to cover everything we need.
    @gaurav
    gaurav committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    47c6df8 View commit details
    Browse the repository at this point in the history

  7. Recreate JAR file on each run. 

    This prevents overlapping class warnings from shaded JARs (https://stackoverflow.com/a/11015175/27310).
    @gaurav
    gaurav committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    bbf672c View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2021

  1. Merge branch 'master' into improvements-from-joss-review

    @gaurav
    gaurav committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    e59ebda View commit details
    Browse the repository at this point in the history