Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove/reword disclaimer in readme #26

Closed
cd-work opened this issue Mar 28, 2023 · 0 comments · Fixed by #27
Closed

Remove/reword disclaimer in readme #26

cd-work opened this issue Mar 28, 2023 · 0 comments · Fixed by #27
Assignees
@cd-work

Comments

@cd-work
Copy link
Collaborator

cd-work commented Mar 28, 2023

Currently the readme includes the following statement:

This library is still under development and not ready to be used yet.

We're already using this in the CLI, which could lead people to the incorrect conclusion that the CLI's sandboxing isn't safe.

Since the Library itself is in a state where there aren't any concrete actionable steps to be taken to improve it, I think it would be best to just remove this statement. More testing and future development will always happen, but we've been successfully using it ourselves without any issues so I wouldn't expect frequent major breaking changes.
cd-work added a commit that referenced this issue Mar 29, 2023
@cd-work
Remove development disclaimer
07daf3a 
There are no plans to make significant changes to the birdcage API in
the near future, so it should be safe for other people to use if
interested.

There also have not been any issues with the security of the provided
sandbox, which makes sense considering Birdcage just delegates to
existing OS sandboxing mechanisms.

Closes #26.
@cd-work cd-work mentioned this issue Mar 29, 2023
Merged
cd-work added a commit that referenced this issue Mar 29, 2023
@cd-work
Remove development disclaimer (#27)
5891a4b 
There are no plans to make significant changes to the birdcage API in
the near future, so it should be safe for other people to use if
interested.

There also have not been any issues with the security of the provided
sandbox, which makes sense considering Birdcage just delegates to
existing OS sandboxing mechanisms.

Closes #26.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cd-work cd-work

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove development disclaimer phylum-dev/birdcage
1 participant
@cd-work