Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unrelated output in parse-sandboxed #1328

Closed
cd-work opened this issue Dec 21, 2023 · 0 comments · Fixed by #1334
Closed

Avoid unrelated output in parse-sandboxed #1328

cd-work opened this issue Dec 21, 2023 · 0 comments · Fixed by #1334
Assignees
@cd-work
Labels
bug Something isn't working

Comments

@cd-work
Copy link
Contributor

cd-work commented Dec 21, 2023

The parse-sandboxed command is designed to be run from within CLI. As a result any output it writes which isn't specific to its operation (like config errors or update notifications) will be duplicated.

The command should be reworked to ensure no output is written that isn't directly related to its purpose.

Currently the following messages are written to stderr:

  • Config access error (we can maybe pass --config /dev/null or add --no-config option)
  • New version available (we already have selfmanage compile-time feature, it should also be a runtime option)
@cd-work cd-work added bug Something isn't working needs triage Needs to be reviewed or assigned labels Dec 21, 2023
@cd-work cd-work mentioned this issue Dec 21, 2023
Closed
cd-work added a commit that referenced this issue Jan 10, 2024
@cd-work
Remove unrelated output from parse-sandboxed
38fc964 
This patch removes all output from `parse-sandboxed` that isn't directly
related to its purpose of parsing dependency files. This includes
omitting both config and update messages.

Closes #1328.
@cd-work cd-work mentioned this issue Jan 10, 2024
Merged
@maxrake maxrake removed the needs triage Needs to be reviewed or assigned label Jan 10, 2024
cd-work added a commit that referenced this issue Jan 10, 2024
@cd-work
Remove unrelated output from parse-sandboxed (#1334)
c11b81c 
This patch removes all output from `parse-sandboxed` that isn't directly
related to its purpose of parsing dependency files. This includes
omitting both config and update messages.

Closes #1328.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cd-work cd-work

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unrelated output from parse-sandboxed phylum-dev/cli
2 participants
@maxrake @cd-work