Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging from parse-sandboxed should be forwarded #1329

Closed
cd-work opened this issue Dec 21, 2023 · 0 comments · Fixed by #1335
Closed

Logging from parse-sandboxed should be forwarded #1329

cd-work opened this issue Dec 21, 2023 · 0 comments · Fixed by #1335
Assignees
@cd-work
Labels
bug Something isn't working needs triage Needs to be reviewed or assigned

Comments

@cd-work
Copy link
Contributor

cd-work commented Dec 21, 2023

Currently anything written to STDERR from parse-sandboxed is swallowed unless the command fails. Once unrelated messages are removed from STDERR (#1328) we should allow both user-facing and hidden log messages to always be forwarded (Stdio::inherit()?) to the parent process.
@cd-work cd-work added bug Something isn't working needs triage Needs to be reviewed or assigned labels Dec 21, 2023
cd-work added a commit that referenced this issue Jan 10, 2024
@cd-work
Forward parse-sandboxed STDERR on success
eccc7c4 
Previously the STDERR of the sandboxed `parse-sandboxed` subcommand was
only forwarded if the command failed. Now the STDERR is always inherited
regardless of exit status.

To ensure optimal troubleshooting in case of a failure, the STDOUT is
now also printed to STDOUT in case of a failure.

Closes #1329.
@cd-work cd-work self-assigned this Jan 10, 2024
@cd-work cd-work mentioned this issue Jan 10, 2024
Merged
cd-work added a commit that referenced this issue Jan 11, 2024
@cd-work
Forward parse-sandboxed STDERR on success (#1335)
54b4d72 
Previously the STDERR of the sandboxed `parse-sandboxed` subcommand was
only forwarded if the command failed. Now the STDERR is always inherited
regardless of exit status.

To ensure optimal troubleshooting in case of a failure, the STDOUT is
now also printed to STDOUT in case of a failure.

Closes #1329.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cd-work cd-work

Labels
bug Something isn't working needs triage Needs to be reviewed or assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Forward parse-sandboxed STDERR on success phylum-dev/cli
1 participant
@cd-work