Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auth list-tokens subcommand #1180

Merged
merged 5 commits into from
Aug 9, 2023
Merged

Add auth list-tokens subcommand #1180

merged 5 commits into from
Aug 9, 2023

Conversation

cd-work
Copy link
Contributor

@cd-work cd-work commented Aug 9, 2023

This patch adds a new list-tokens subcommand to the existing auth subcommand which lists all locksmith tokens associated with the logged in user.

See #1176.

@cd-work
Add auth list-tokens subcommand
652fa5c 
This patch adds a new `list-tokens` subcommand to the existing `auth`
subcommand which lists all locksmith tokens associated with the logged
in user.

See #1176.
@cd-work
Regenerate documentation
3da13a4
@cd-work cd-work requested a review from a team as a code owner August 9, 2023 17:10
@cd-work cd-work requested a review from maxrake August 9, 2023 17:10
@cd-work
Copy link
Contributor Author

cd-work commented Aug 9, 2023

This is what the new endpoint's output looks like:

tmp

kylewillmon
kylewillmon reviewed Aug 9, 2023
View reviewed changes
cli/src/api/endpoints.rs Show resolved Hide resolved
cli/src/types.rs Show resolved Hide resolved
kylewillmon
kylewillmon previously approved these changes Aug 9, 2023
View reviewed changes
maxrake
maxrake approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works as expected/intended. Some questions were asked out of band and a suggested change for the CHANGELOG was already implemented. LGTM.

@cd-work cd-work merged commit 8bc7337 into main Aug 9, 2023
14 checks passed
@cd-work cd-work deleted the list_tokens branch August 9, 2023 18:05
@maxrake maxrake linked an issue Aug 9, 2023 that may be closed by this pull request
List and revoke API keys #1176
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxrake maxrake maxrake approved these changes

@kylewillmon kylewillmon kylewillmon left review comments

Assignees

@cd-work cd-work

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List and revoke API keys
3 participants
@cd-work @kylewillmon @maxrake