Add phylum auth revoke-token subcommand
#1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new subcommand to the `auth` subcommand which allows revoking Locksmith API tokens. It is possible to either specify one or more tokens as CLI arguments, or alternatively interactively select which tokens should be revoked. Closes #1176.
maxrake
requested changes
Aug 9, 2023
There was a problem hiding this comment.
Confirmed with local testing. The UX LGTM.
There are a few documentation related changes that are requested. Also, while not directly related to this PR, it might be worth changing doc_templates/phylum_auth_set-token.md at this time to reference API keys in the examples instead of OIDC tokens.
There are also some clippy errors showing in the CI checks.
maxrake
requested changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new subcommand to the
authsubcommand which allowsrevoking Locksmith API tokens.
It is possible to either specify one or more tokens as CLI arguments, or
alternatively interactively select which tokens should be revoked.
Closes #1176.
Small Disclaimer: I might have gone a little overboard with the implementation of this issue, however I do believe that the ease of use provided by the selection UI justifies the small additional code complexity.