Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pre-installed rustup #1506

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Use pre-installed rustup #1506

merged 1 commit into from
Sep 26, 2024

Conversation

kylewillmon
Copy link
Contributor

All of our runners (including self-hosted runners) now have rustup available. So this patch removes the use of curl to install it.

@kylewillmon kylewillmon self-assigned this Sep 26, 2024
@kylewillmon kylewillmon requested a review from a team as a code owner September 26, 2024 21:11
@kylewillmon
Copy link
Contributor Author

kylewillmon commented Sep 26, 2024

I've manually triggered the release workflow on this branch here.

All of our runners (including self-hosted runners) now have rustup
available. So this patch removes the use of curl to install it.
@maxrake
Copy link
Contributor

maxrake commented Sep 26, 2024

Still not working on the manually triggered release workflow. I'll hold off a bit on this review.

@kylewillmon
Copy link
Contributor Author

Still not working on the manually triggered release workflow.

It looks like one of the old runners was still around to pick up the job... I assumed enough time had passed that they would all be using the new image. A re-run should resolve the issue (as soon as GitHub lets me re-run it)

Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kylewillmon kylewillmon merged commit a3cd770 into main Sep 26, 2024
25 checks passed
@kylewillmon kylewillmon deleted the trustup branch September 26, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants