Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json : use double quotes instead of single quotes #1400

Open
Marc-pi opened this issue Feb 8, 2016 · 0 comments
Open

json : use double quotes instead of single quotes #1400

Marc-pi opened this issue Feb 8, 2016 · 0 comments

Comments

@Marc-pi
Copy link
Member

Marc-pi commented Feb 8, 2016

we're encountering frequent issues with json and gettext values : in case of latin language, there is a frequent usage of apostrophe ', that breaks code

example
module/user/template/front/account-index.phtml

if (result.email_error === 0) { this.emailInitVal = result.email_value; this.$email.after('<span class="help-block">' + result.email_message + '</span>'); }

need to be replaced to

if (result.email_error === 0) { this.emailInitVal = result.email_value; this.$email.after("<span class='help-block'>" + result.email_message + "</span>"); }

=> so there are a lot of area in Pi code where we have to make this change
=> and we must take the abbit to use double quote like this in your json outputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants